Re: [ros-dev] [ros-diffs] [tfaber] 63032: [NETCFGX] - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges CORE-8115 #resolve

[Thomas Faber]

Uh, this is missing the "Patch by Víctor Martínez" part, sorry.

On 2014-04-28 10:27, [e-mail] wrote:
> Author: tfaber
> Date: Mon Apr 28 08:27:57 2014
> New Revision: 63032
>
> URL: http://svn.reactos.org/svn/reactos?rev=63032&view=rev
> Log:
> [NETCFGX]
> Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges
>
> CORE-8115 #resolve
>
> Modified:
>     trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c
>
> Modified: trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/tcpipconf...
> ==============================================================================
> --- trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c	[iso-8859-1] Mon Apr 28 08:27:57 2014
> @@ -3141,7 +3141,7 @@
>      //MessageBoxW(NULL, L"INetCfgComponentControl_fnApplyRegistryChanges", NULL, MB_OK);
> if (RegCreateKeyExW(hKey, L"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS)
> if (RegCreateKeyExW(HKEY_LOCAL_MACHINE, L"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS)
> {
>     if (pCurrentConfig->pDNS)
>     {

[victor martinez]

No I don't accept the "sorryness". Well, I just accept them if you promise to look my RTL tests from your TODO list. Deal? jkjk
> Date: Mon, 28 Apr 2014 10:31:44 +0200
> From: [e-mail]
> To: [e-mail]
> Subject: Re: [ros-dev] [ros-diffs] [tfaber] 63032: [NETCFGX] - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges CORE-8115 #resolve
>
> Uh, this is missing the "Patch by Víctor Martínez" part, sorry.
>
> On 2014-04-28 10:27, [e-mail] wrote:
> > Author: tfaber
> > Date: Mon Apr 28 08:27:57 2014
> > New Revision: 63032
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=63032&view=rev
> > Log:
> > [NETCFGX]
> > Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges
> >
> > CORE-8115 #resolve
> >
> > Modified:
> >     trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c
> >
> > Modified: trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c
> > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/tcpipconf...
> > ==============================================================================
> > --- trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c	[iso-8859-1] (original)
> > +++ trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c	[iso-8859-1] Mon Apr 28 08:27:57 2014
> > @@ -3141,7 +3141,7 @@
> >      //MessageBoxW(NULL, L"INetCfgComponentControl_fnApplyRegistryChanges", NULL, MB_OK);
> > if (RegCreateKeyExW(hKey, L"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS)
> > if (RegCreateKeyExW(HKEY_LOCAL_MACHINE, L"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS)
> > {
> >     if (pCurrentConfig->pDNS)
> >     {
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev