Re: [ros-diffs] [gvg] 18468: Make sure we don't hang forever when activating a window belonging to

[Gunnar Dalsnes]

gvg(a)svn.reactos.com wrote:
>   
>  -      co_IntSendMessage(Window->hSelf, WM_WINDOWPOSCHANGING, 0, (LPARAM) WinPos);
>  
>  +      co_IntPostOrSendMessage(Window->hSelf, WM_WINDOWPOSCHANGING, 0, (LPARAM)
> WinPos);
>   
I think the whole co_IntPostOrSendMessage function is wrong and crazy. 
Who made it? Sending and posting messages are completely different things.

I think something like co_IntSendMessageTimeout should be used instead, 
but i dont think its implemented yet.

G.

[Ge van Geldorp]

>   From: Gunnar Dalsnes
>  
>  I think the whole co_IntPostOrSendMessage function is wrong 
>  and crazy. 
>  Who made it? Sending and posting messages are completely 
>  different things.
>  
>  I think something like co_IntSendMessageTimeout should be 
>  used instead, but i dont think its implemented yet. 
Co_IntSendMessageTimeout is indeed implemented. And yes, testing shows that
under Windows these messages are either sent directly or not sent at all (if
the receiving thread is blocked), no PostMessage() going on at all.

Gé van Geldorp.

[Filip Navara]

Ge van Geldorp wrote:

> >  From: Gunnar
> > Dalsnes
> >
> > I think the whole co_IntPostOrSendMessage function is wrong 
> > and crazy. 
> > Who made it? Sending and posting messages are completely 
> > different things.
> >
> > I think something like co_IntSendMessageTimeout should be 
> > used instead, but i dont think its implemented yet.
> >     
> >  
> Co_IntSendMessageTimeout is indeed implemented. And yes, testing shows that
> under Windows these messages are either sent directly or not sent at all (if
> the receiving thread is blocked), no PostMessage() going on at all.
>
> Gé van Geldorp.
>   
>  
On Windows there is a mechanism called event queue. You can queue a 
special message into message queue which acts as an event (Destroy 
Window, Show Window, Set Window Pos, Activate, Deactivate, ...) and is 
used for handling such cases as doing SetWindowPos on another thread's 
window ...

- Filip

[Gunnar Dalsnes]

> >   
>  On
> Windows there is a mechanism called event queue. You can queue a 
>  special message into message queue which acts as an event (Destroy 
>  Window, Show Window, Set Window Pos, Activate, Deactivate, ...) and is 
>  used for handling such cases as doing SetWindowPos on another thread's 
>  window ... 
Posted window messages are for events so this already exist. Can you 
tell more about this?

G.

>   
>  - Filip
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  
>  
>