Re: [ros-dev] [ros-diffs] [jgardou] 49281: [PSDK] - Add MIDL_user_allocate and MIDL_user_free definitions - #ifdef a GCC hack

[Timo Kreuzer]

Am 26.10.2010 18:01, schrieb jgardou(a)svn.reactos.org:
>   +#ifdef __GCC__
>   /* Note: this should return a CLIENT_CALL_RETURN, but calling convention for
>    * returning structures/unions is different between Windows and gcc on i386. */
>   LONG_PTR RPC_VAR_ENTRY
>  @@ -659,6 +663,13 @@
>     NdrAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ... );
>   LONG_PTR RPC_VAR_ENTRY
>     NdrDcomAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ...
> );
>  +#else
>  +CLIENT_CALL_RETURN RPC_VAR_ENTRY NdrClientCall2(
>  +  PMIDL_STUB_DESC pStubDescriptor,
>  +  PFORMAT_STRING pFormat,
>  +  ...
>  +);
>  +#endif
>    
Is this hack even neccessary? I couldn't see any difference between gcc
and msvc with the correct prototype.
Both return the result in eax.

[Jérôme Gardou]

good, tell WINE then :-/
Timo Kreuzer wrote:
>   Am 26.10.2010 18:01, schrieb jgardou(a)svn.reactos.org:
> >   +#ifdef __GCC__
> >    /* Note: this should return a CLIENT_CALL_RETURN, but calling convention for
> >     * returning structures/unions is different between Windows and gcc on i386. */
> >    LONG_PTR RPC_VAR_ENTRY
> >  @@ -659,6 +663,13 @@
> >      NdrAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ... );
> >    LONG_PTR RPC_VAR_ENTRY
> >      NdrDcomAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ...
> > );
> >  +#else
> >  +CLIENT_CALL_RETURN RPC_VAR_ENTRY NdrClientCall2(
> >  +  PMIDL_STUB_DESC pStubDescriptor,
> >  +  PFORMAT_STRING pFormat,
> >  +  ...
> >  +);
> >  +#endif
> >        
>  Is this hack even neccessary? I couldn't see any difference between gcc
>  and msvc with the correct prototype.
>  Both return the result in eax.
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>