Question about commits with no commit log, or commits with no files but just the log, on Git.

[Hermès BÉLUSCA - MAÏTO]

‌Hello all,<br>
<br>
After having noticed
https://github.com/reactos/reactos/commit/50ae5e7c5268222718174221366169e2b…
I am wondering whether it is possible to add mechanisms (like git pre-commit hooks) that
check for, and<br>
prevent potential problematic commits like, commits without commit log, or commits with no
files (but with a log).<br>
<br>
Any ideas?<br>
<br>
Cheers,<br>
Hermes

[Colin Finck]

Am 16.10.2017 um 12:22 schrieb Hermès BÉLUSCA - MAÏTO:> After having noticed
>  
> https://github.com/reactos/reactos/commit/50ae5e7c5268222718174221366169e2b…
>  I am wondering whether it is possible to add mechanisms (like git
>  pre-commit hooks) that check for, and
>  prevent potential problematic commits like, commits without commit log,
>  or commits with no files (but with a log). 
Not using GitHub.
But you are all more than welcome to request that feature independent of
each other and maybe they consider it for the future :)

It may be possible though that we ship a number of client-side Git hooks
and settings with RosBE. Setting "pull.rebase=1" by default may be
another candidate.


- Colin

[David Quintana (gigaherz)]

Commit hooks in git exist, but *locally*. You can install them on your own
repository. If you write such a scripy, feel free to share it so others can
benefit!

On 16 Oct 2017 12:38 pm, "Colin Finck" <colin(a)reactos.org> wrote:

>   Am 16.10.2017 um 12:22 schrieb Hermès BÉLUSCA -
> MAÏTO:> After having
>  noticed
> >  
> > https://github.com/reactos/reactos/commit/50ae5e7c5268222718174221366169 
> e2b115b06a
> >   I am wondering whether it is possible to add
> > mechanisms (like git
> >  pre-commit hooks) that check for, and
> >  prevent potential problematic commits like, commits without commit log,
> >  or commits with no files (but with a log). 
>  Not using GitHub.
>  But you are all more than welcome to request that feature independent of
>  each other and maybe they consider it for the future :)
>
>  It may be possible though that we ship a number of client-side Git hooks
>  and settings with RosBE. Setting "pull.rebase=1" by default may be
>  another candidate.
>
>
>  - Colin
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Alexander Sh.]

We can install such stuff in JIRA.
Like this one:
https://marketplace.atlassian.com/plugins/com.midori.jira.plugin.jira-commi…
This Git integration tool has such capabilities as well:
https://marketplace.atlassian.com/plugins/com.xiplink.jira.git.jira_git_plu…
We even have a ticket for the latter:
https://jira.reactos.org/browse/ONLINE-731

- Alexander

2017-10-16 13:41 GMT+03:00 David Quintana (gigaherz) <gigaherz(a)gmail.com>om>:

>   Commit hooks in git exist, but *locally*. You can
> install them on your own
>  repository. If you write such a scripy, feel free to share it so others can
>  benefit!
>
>  On 16 Oct 2017 12:38 pm, "Colin Finck" <colin(a)reactos.org> wrote:
>
> >   Am 16.10.2017 um 12:22 schrieb Hermès BÉLUSCA -
> > MAÏTO:> After having
> >  noticed
> > >  
> > > https://github.com/reactos/reactos/commit/50ae5e7c5268222718 
> > 174221366169e2b115b06a
> > >   I am wondering whether it is possible to add
> > > mechanisms (like git
> > >  pre-commit hooks) that check for, and
> > >  prevent potential problematic commits like, commits without commit log,
> > >  or commits with no files (but with a log). 
> >  Not using GitHub.
> >  But you are all more than welcome to request that feature independent of
> >  each other and maybe they consider it for the future :)
> >
> >  It may be possible though that we ship a number of client-side Git hooks
> >  and settings with RosBE. Setting "pull.rebase=1" by default may be
> >  another candidate.
> >
> >
> >  - Colin
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>