Re: [ros-dev] [ros-diffs] [pschweitzer] 50021: [NTOSKRNL] Rewritten FsRtlIsDbcsInExpression() using FsRtlIsNameInExpression() pattern. This fixes all failing tests from kmtest.sys and make this function definitely tastier t...

[Ged Murphy]

[e-mail] wrote:
> ASSERT(Name->Length);
> ASSERT(Expression->Length);
> ASSERT(!FsRtlDoesDbcsContainWildCards(Name));

It'd be preferable to wrap that last ASSERT so it isn't compiled into release builds.
Adding functions into asserts adds overhead on release builds as they're called for no reason.

Ged.

[Timo Kreuzer]

Am 13.12.2010 12:39, schrieb Ged Murphy:
> [e-mail] wrote:
> > ASSERT(Name->Length);
> > ASSERT(Expression->Length);
> > ASSERT(!FsRtlDoesDbcsContainWildCards(Name));
>
> It'd be preferable to wrap that last ASSERT so it isn't compiled into release builds.
> Adding functions into asserts adds overhead on release builds as they're called for no reason.

Shouldn't ASSERT() be defined to nothing on release builds?

[Ged Murphy]

Timo Kreuzer wrote:
> Shouldn't ASSERT() be defined to nothing on release builds?

So they are. I thought we executed the condition but didn't test it.
My fault.