Yarotows trunk integration

[Gregor Schneider]

Hi,

good to see the branch work back in trunk, I suspected this work would be
left to rot and finally be forgotten (like in most other experimental
branches). Altogether this looks like a huge step forward, got to test those
mode switches it once I have enough time.

One thing I noticed from the diffs is the eng/mem.c file, which exceeded my
EVIL / HACK threshold. Is this supposed to stay - especially in the context
of ARM3's to be proven awesomeness?

--- snippet ---

EngSecureMem(PVOID Address, ULONG Length)
{ return (HANDLE)-1; // HACK!!! }

EngUnsecureMem(HANDLE Mem)
{ if (Mem == (HANDLE)-1) return;  // HACK!!! }

--- snippet ---

Good work anyway, thanks to the people involved!

Regards,
Gregor

[Timo Kreuzer]

The problem is missing MmSecureVirtualMemory. The new Mm code is a big
step into this direction, so I guess it won't take long until it's
implemented. Until that we can probably live with the hack.

Am 25.10.2010 20:43, schrieb Gregor Schneider:
> Hi,
>
> good to see the branch work back in trunk, I suspected this work would
> be left to rot and finally be forgotten (like in most other
> experimental branches). Altogether this looks like a huge step
> forward, got to test those mode switches it once I have enough time.
>
> One thing I noticed from the diffs is the eng/mem.c file, which
> exceeded my EVIL / HACK threshold. Is this supposed to stay -
> especially in the context of ARM3's to be proven awesomeness?
>
> --- snippet ---
>
> EngSecureMem(PVOID Address, ULONG Length)
> { return (HANDLE)-1; // HACK!!! }
>
> EngUnsecureMem(HANDLE Mem)
> { if (Mem == (HANDLE)-1) return;  // HACK!!! }
>
> --- snippet ---
>
> Good work anyway, thanks to the people involved!
>
> Regards,
> Gregor
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Olaf Siejka]

This should be reported as HACK tagged bug, i can do it provided someone
will write up a short description.

W dniu 25 października 2010 22:36 użytkownik Timo Kreuzer <
[e-mail]> napisał:
> The problem is missing MmSecureVirtualMemory. The new Mm code is a big step
> into this direction, so I guess it won't take long until it's implemented.
> Until that we can probably live with the hack.

[Ged Murphy]

//TODO and //HACK, etc in code are easily lost and forgotten about.

I think it's time reactos started to move towards a set of '#pragma message'
defines instead of losing messages of hacked or unfinished code.

Ged.

2010/10/25 Olaf Siejka [e-mail]
> This should be reported as HACK tagged bug, i can do it provided someone
> will write up a short description.
>
> W dniu 25 października 2010 22:36 użytkownik Timo Kreuzer <
> [e-mail]> napisał:
> > The problem is missing MmSecureVirtualMemory. The new Mm code is a big
> > step into this direction, so I guess it won't take long until it's
> > implemented. Until that we can probably live with the hack.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Olaf Siejka]

For similar effect I am trying to map out and record every known hack or
unimplemented functionality:

http://www.reactos.org/wiki/Bug_Filters#Hacks

W dniu 25 października 2010 23:15 użytkownik Ged Murphy <[e-mail]
> napisał:
> //TODO and //HACK, etc in code are easily lost and forgotten about.
>
> I think it's time reactos started to move towards a set of '#pragma
> message' defines instead of losing messages of hacked or unfinished code.
>
> Ged.

[Javier Agustìn Fernàndez Arroyo]

and what about using DPRINT1("HACK:.......<<whatever>>);

2010/10/25 Olaf Siejka [e-mail]
> For similar effect I am trying to map out and record every known hack or
> unimplemented functionality:
>
> http://www.reactos.org/wiki/Bug_Filters#Hacks
>
> W dniu 25 października 2010 23:15 użytkownik Ged Murphy <
> [e-mail]> napisał:
>
> //TODO and //HACK, etc in code are easily lost and forgotten about.
> > I think it's time reactos started to move towards a set of '#pragma
> > message' defines instead of losing messages of hacked or unfinished code.
> >
> > Ged.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Adam Kachwalla]

The issue I see with that is that it will clog up debug logs, when  
attempting to solve certain problems.

Since the hacks only really need to be sorted out (and can only be sorted  
out) during compile time, I am not sure there's much point polluting the  
debug log with all that.
Simple #pragma message things are fine IMO.

On Tue, 26 Oct 2010 18:29:20 +1100, Javier Agustìn Fernàndez Arroyo  
[e-mail] wrote:
> and what about using DPRINT1("HACK:.......<<whatever>>);
>
> 2010/10/25 Olaf Siejka [e-mail]
> > For similar effect I am trying to map out and record every known hack  
> > or unimplemented functionality:
> >
> > http://www.reactos.org/wiki/Bug_Filters#Hacks
> >
> > W dniu 25 października 2010 23:15 użytkownik Ged Murphy  
> > [e-mail] napisał:
> > > //TODO and //HACK, etc in code are easily lost and forgotten about.
> > >
> > > I think it's time reactos started to move towards a set of '#pragma  
> > > message' defines instead of losing messages of hacked or unfinished  
> > > code.
> > >
> > > Ged.
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Give a man a fish and he will eat for a day.
Teach a man to fish and he will eat for a lifetime.
Give a man religion and he will die praying for a fish.