New subject: [ros-diffs] [akhaldi] 68155: [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details.

16 Jun 2015

If you look at the autogenerated file, you'll find this:

[AddReg.NTarm]
; RAM Disk class driver
HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ErrorControl",0x00010001,0x00000000
HKLM,"SYSTEM\CurrentControlSet\Services\Disk","ImagePath",0x00020000,"system32\drivers\ramdisk.sys"
HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Start",0x00010001,0x00000000
HKLM,"SYSTEM\CurrentControlSet\Services\Disk","Type",0x00010001,0x00000001

HKLM,"SYSTEM\CurrentControlSet\Services\fastfat","Start",0x00010001,0x00000003

; EOF
; MS Styles (Themes)
HKCR,".msstyles","",0x00000000,"msstylesfile"
HKCR,"msstylesfile","",0x00000000,"Visual Style File"
HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"
HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenMSTheme file:""%1"""

; Theme File
HKCR,".theme","",0x00000000,"themefile"
HKCR,"themefile","",0x00000000,"Theme File"
HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"
HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenTheme /file:""%1"""

And now figure out, why it didn't work.

Am 15.06.2015 um 22:42 schrieb akhaldi(a)svn.reactos.org:
...
  Author: akhaldi
 Date: Mon Jun 15 20:42:08 2015
 New Revision: 68155

 URL: http://svn.reactos.org/svn/reactos?rev=68155&view=rev
 Log:
 [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out
why that doesn't work is left as an exercise for the reader. See CORE-5984 for
details.

 Removed:
      trunk/reactos/dll/win32/themeui/themeui_reg.inf
 Modified:
      trunk/reactos/boot/bootdata/hivecls.inf
      trunk/reactos/dll/win32/themeui/CMakeLists.txt

 Modified: trunk/reactos/boot/bootdata/hivecls.inf
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?…
 ==============================================================================
 --- trunk/reactos/boot/bootdata/hivecls.inf	[iso-8859-1] (original)
 +++ trunk/reactos/boot/bootdata/hivecls.inf	[iso-8859-1] Mon Jun 15 20:42:08 2015
 @@ -284,6 +284,18 @@
   HKCR,"sysfile","NoOpen",0x00000000,""

HKCR,&quot;sysfile&quot;,&quot;FriendlyTypeName&quot;,0x00020000,&quot;(a)%SystemRoot%\system32\shell32.dll,-171&quot;

HKCR,"sysfile\DefaultIcon","",0x00020000,"%SystemRoot%\system32\shell32.dll,-154"
 +
 +; MS Styles (Themes)
 +HKCR,".msstyles","",0x00000000,"msstylesfile"
 +HKCR,"msstylesfile","",0x00000000,"Visual Style File"

+HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"

+HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenMSTheme file:""%1"""
 +
 +; Theme File
 +HKCR,".theme","",0x00000000,"themefile"
 +HKCR,"themefile","",0x00000000,"Theme File"

+HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"

+HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenTheme /file:""%1"""

   ; URL shortcuts (e.g. used in favorites folder of IExplorer)
   HKCR,".url","",0x00000000,"InternetShortcut"

 Modified: trunk/reactos/dll/win32/themeui/CMakeLists.txt
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/CMakeLis…
 ==============================================================================
 --- trunk/reactos/dll/win32/themeui/CMakeLists.txt	[iso-8859-1] (original)
 +++ trunk/reactos/dll/win32/themeui/CMakeLists.txt	[iso-8859-1] Mon Jun 15 20:42:08 2015
 @@ -1,5 +1,4 @@

   add_library(themeui SHARED themeui.rc)
   set_module_type(themeui win32dll ENTRYPOINT 0)
 -add_registry_inf(themeui_reg.inf)
   add_cd_file(TARGET themeui DESTINATION reactos/system32 FOR all)

 Removed: trunk/reactos/dll/win32/themeui/themeui_reg.inf
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/themeui/themeui_…
 ==============================================================================
 --- trunk/reactos/dll/win32/themeui/themeui_reg.inf	[iso-8859-1] (original)
 +++ trunk/reactos/dll/win32/themeui/themeui_reg.inf	(removed)
 @@ -1,11 +0,0 @@
 -; MS Styles (Themes)
 -HKCR,".msstyles","",0x00000000,"msstylesfile"
 -HKCR,"msstylesfile","",0x00000000,"Visual Style File"

-HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"

-HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenMSTheme file:""%1"""
 -
 -; Theme File
 -HKCR,".theme","",0x00000000,"themefile"
 -HKCR,"themefile","",0x00000000,"Theme File"

-HKCR,"themefile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1"

-HKCR,"themefile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe
shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance
/Action:OpenTheme /file:""%1"""

Re: [ros-dev] [ros-diffs] [akhaldi] 68155: [THEMEUI] Revert r67304 (Leverage add_registry_inf() as suggested by Timo). Figuring out why that doesn't work is left as an exercise for the reader. See CORE-5984 for details.