Re: [ros-dev] [ros-diffs] [mbosma] 25812: Lester Kortenhoeven (lester(at)ko rtenhoeven(dot)de)

[Murphy, Ged (Bolton)]

mbosma(a)svn.reactos.org wrote:

>   +WCHAR ApplicationText[700]; 
...
>   - 
StrCatW(DescriptionText,
Strings[IDS_VERSION]);
>   - 
StrCatW(DescriptionText,
SelectedApplication->Version);
>   - 
StrCatW(DescriptionText, L"\n");
>   + 
StrCatW(ApplicationText,
Strings[IDS_VERSION]);
>   + 
StrCatW(ApplicationText,
SelectedApplication->Version);
>   + 
StrCatW(ApplicationText, L"\n");


This doesn't fix anything, there is still a potential overflow issue.
Quickly skimming through the app, there are numerous other issues too.

Ged.


Registered Office: PO Box 1 Salford Road, Over Hulton, Bolton, BL5 1DD.
Registered in England: No. 2375355 
The information contained in this message or any of its attachments is
confidential and is intended for the exclusive use of the addressee. The
information may also be legally privileged. The views expressed may not be
company policy, but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other dissemination
or use of this communication is strictly prohibited. If you have received
this message in error, please contact postmaster(a)eu.exide.com
<mailto:[e-mail]> and then delete this message. 
Exide Technologies is an industrial and transportation battery producer and
recycler with operations in 89 countries. Further information can be found
at www.exide.com <www.exide.com>