Re: [ros-dev] [ros-diffs] [jgardou] 64396: [NTOS/CM] - Add NtQueryKey(KeyNameInformation) implementation. CORE-8581 #resolve

[Timo Kreuzer]

A few remarks:
- There should be only one SEH, not for performance, but since the
KeyNameInfo->NameLength = 0; needs to be in SEH as well
- The function duplicates a lot of code from CmpConstructName, possibly
even incomplete
- There was already an implementation in the kernel-fun branch

Unrelated to your code, just something I spotted in that file:
- CmpQueryKeyData cannot be wrapped in SEH (it would cause reference
leaks on exception), but is wrapped in SEH in CmEnumerateKey
- CmpQueryKeyData does not use SEH, but is called with user mode
pointers from CmQueryKey

Timo

Am 29.09.2014 18:27, schrieb [e-mail]:
> Author: jgardou
> Date: Mon Sep 29 16:27:16 2014
> New Revision: 64396
>
> URL: http://svn.reactos.org/svn/reactos?rev=64396&view=rev
> Log:
> [NTOS/CM]
> Add NtQueryKey(KeyNameInformation) implementation.
>
> CORE-8581 #resolve