Re: [ros-dev] [ros-diffs] [dgorbachev] 27107: Fix issue #2151.

[Thomas Weidenmueller]

Do you even know what you're doing? I've seen many commits where you
call something a FIX and then just comment code out and add another
FIXME....

[e-mail] wrote:
> Author: dgorbachev
> Date: Sun Jun 10 15:11:05 2007
> New Revision: 27107
>
> URL: http://svn.reactos.org/svn/reactos?rev=27107&view=rev
> Log:
> Fix issue #2151.
>
> Modified:
>     trunk/reactos/ntoskrnl/mm/sysldr.c
>
> Modified: trunk/reactos/ntoskrnl/mm/sysldr.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/sysldr.c?rev=27...
> ==============================================================================
> --- trunk/reactos/ntoskrnl/mm/sysldr.c (original)
> +++ trunk/reactos/ntoskrnl/mm/sysldr.c Sun Jun 10 15:11:05 2007
> @@ -1767,7 +1767,7 @@
>                                     NtHeader->OptionalHeader.AddressOfEntryPoint);
>      LdrEntry->SizeOfImage = DriverSize;
>      LdrEntry->CheckSum = NtHeader->OptionalHeader.CheckSum;
> LdrEntry->SectionPointer = LdrEntry;
>
> LdrEntry->SectionPointer = NULL; // ?
>
> /* Now write the DLL name */
> LdrEntry->BaseDllName.Buffer = (PVOID)(LdrEntry + 1);

> Do you even know what you're doing? I've seen many commits where you
> call something a FIX and then just comment code out and add another
> FIXME....

Write a good fix. I wrote bug report a long time ago, but it seems that 
nobody cares.