Re: [ros-dev] [ros-diffs] [cgutman] 47286: [DHCP] - Delete the old dhcp service - Part 1 of x

[Aleksey Bragin]

I'm afraid you just deleted all dhcp development history. Please  
revert these 3 commits and redo them properly using svn copy + svn  
delete.

WBR,
Aleksey Bragin.


On May 21, 2010, at 9:44 AM, cgutman(a)svn.reactos.org wrote:

>   Author: cgutman
>  Date: Fri May 21 07:44:35 2010
>  New Revision: 47286
>
>  URL: http://svn.reactos.org/svn/reactos?rev=47286&view=rev
>  Log:
>  [DHCP]
>  - Delete the old dhcp service
>  - Part 1 of x
>
>  Removed:
>      trunk/reactos/base/services/dhcp/adapter.c
>      trunk/reactos/base/services/dhcp/alloc.c
>      trunk/reactos/base/services/dhcp/api.c
>      trunk/reactos/base/services/dhcp/compat.c
>      trunk/reactos/base/services/dhcp/design.txt
>      trunk/reactos/base/services/dhcp/dhclient.c
>      trunk/reactos/base/services/dhcp/dhcp.rbuild
>      trunk/reactos/base/services/dhcp/dhcp.rc
>      trunk/reactos/base/services/dhcp/dhcpmain.c
>      trunk/reactos/base/services/dhcp/dispatch.c
>      trunk/reactos/base/services/dhcp/hash.c
>      trunk/reactos/base/services/dhcp/include/cdefs.h
>      trunk/reactos/base/services/dhcp/include/debug.h
>      trunk/reactos/base/services/dhcp/include/dhcp.h
>      trunk/reactos/base/services/dhcp/include/dhcpd.h
>      trunk/reactos/base/services/dhcp/include/dhctoken.h
>      trunk/reactos/base/services/dhcp/include/hash.h
>      trunk/reactos/base/services/dhcp/include/inet.h
>      trunk/reactos/base/services/dhcp/include/osdep.h
>      trunk/reactos/base/services/dhcp/include/predec.h
>      trunk/reactos/base/services/dhcp/include/privsep.h
>      trunk/reactos/base/services/dhcp/include/rosdhcp.h
>      trunk/reactos/base/services/dhcp/include/site.h
>      trunk/reactos/base/services/dhcp/include/stdint.h
>      trunk/reactos/base/services/dhcp/include/sysconf.h
>      trunk/reactos/base/services/dhcp/include/tree.h
>      trunk/reactos/base/services/dhcp/include/version.h
>      trunk/reactos/base/services/dhcp/memory.c
>      trunk/reactos/base/services/dhcp/options.c
>      trunk/reactos/base/services/dhcp/pipe.c
>      trunk/reactos/base/services/dhcp/privsep.c
>      trunk/reactos/base/services/dhcp/socket.c
>      trunk/reactos/base/services/dhcp/tables.c
>      trunk/reactos/base/services/dhcp/timer.c
>      trunk/reactos/base/services/dhcp/tree.c
>      trunk/reactos/base/services/dhcp/util.c

[Daniel Reimer]

  Small addition from Johannes Anderwald who cant post here right now 
because iserv is mad at him.

Could you please use File Headers following the commonly used ReactOS 
Standard?

Am 21.05.2010 10:24, schrieb Aleksey Bragin:
>   I'm afraid you just deleted all dhcp development
> history. Please 
>  revert these 3 commits and redo them properly using svn copy + svn 
>  delete.
>
>  WBR,
>  Aleksey Bragin.
>
>
>  On May 21, 2010, at 9:44 AM, cgutman(a)svn.reactos.org wrote:
>
> >   Author: cgutman
> >  Date: Fri May 21 07:44:35 2010
> >  New Revision: 47286
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=47286&view=rev
> >  Log:
> >  [DHCP]
> >  - Delete the old dhcp service
> >  - Part 1 of x
> >
> >  Removed:
> >      trunk/reactos/base/services/dhcp/adapter.c
> >      trunk/reactos/base/services/dhcp/alloc.c
> >      trunk/reactos/base/services/dhcp/api.c
> >      trunk/reactos/base/services/dhcp/compat.c
> >      trunk/reactos/base/services/dhcp/design.txt
> >      trunk/reactos/base/services/dhcp/dhclient.c
> >      trunk/reactos/base/services/dhcp/dhcp.rbuild
> >      trunk/reactos/base/services/dhcp/dhcp.rc
> >      trunk/reactos/base/services/dhcp/dhcpmain.c
> >      trunk/reactos/base/services/dhcp/dispatch.c
> >      trunk/reactos/base/services/dhcp/hash.c
> >      trunk/reactos/base/services/dhcp/include/cdefs.h
> >      trunk/reactos/base/services/dhcp/include/debug.h
> >      trunk/reactos/base/services/dhcp/include/dhcp.h
> >      trunk/reactos/base/services/dhcp/include/dhcpd.h
> >      trunk/reactos/base/services/dhcp/include/dhctoken.h
> >      trunk/reactos/base/services/dhcp/include/hash.h
> >      trunk/reactos/base/services/dhcp/include/inet.h
> >      trunk/reactos/base/services/dhcp/include/osdep.h
> >      trunk/reactos/base/services/dhcp/include/predec.h
> >      trunk/reactos/base/services/dhcp/include/privsep.h
> >      trunk/reactos/base/services/dhcp/include/rosdhcp.h
> >      trunk/reactos/base/services/dhcp/include/site.h
> >      trunk/reactos/base/services/dhcp/include/stdint.h
> >      trunk/reactos/base/services/dhcp/include/sysconf.h
> >      trunk/reactos/base/services/dhcp/include/tree.h
> >      trunk/reactos/base/services/dhcp/include/version.h
> >      trunk/reactos/base/services/dhcp/memory.c
> >      trunk/reactos/base/services/dhcp/options.c
> >      trunk/reactos/base/services/dhcp/pipe.c
> >      trunk/reactos/base/services/dhcp/privsep.c
> >      trunk/reactos/base/services/dhcp/socket.c
> >      trunk/reactos/base/services/dhcp/tables.c
> >      trunk/reactos/base/services/dhcp/timer.c
> >      trunk/reactos/base/services/dhcp/tree.c
> >      trunk/reactos/base/services/dhcp/util.c 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Ged Murphy]

Most of it isn't our code, it's from the ISC.
You shouldn't be changing the headers in these files

-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Daniel Reimer
Sent: 21 May 2010 09:37
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [cgutman] 47286: [DHCP] - Delete the old
dhcp service - Part 1 of x

  Small addition from Johannes Anderwald who cant post here right now 
because iserv is mad at him.

Could you please use File Headers following the commonly used ReactOS 
Standard?

Am 21.05.2010 10:24, schrieb Aleksey Bragin:
>   I'm afraid you just deleted all dhcp development
> history. Please 
>  revert these 3 commits and redo them properly using svn copy + svn 
>  delete.
>
>  WBR,
>  Aleksey Bragin.
>
>
>  On May 21, 2010, at 9:44 AM, cgutman(a)svn.reactos.org wrote:
>
> >   Author: cgutman
> >  Date: Fri May 21 07:44:35 2010
> >  New Revision: 47286
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=47286&view=rev
> >  Log:
> >  [DHCP]
> >  - Delete the old dhcp service
> >  - Part 1 of x
> >
> >  Removed:
> >      trunk/reactos/base/services/dhcp/adapter.c
> >      trunk/reactos/base/services/dhcp/alloc.c
> >      trunk/reactos/base/services/dhcp/api.c
> >      trunk/reactos/base/services/dhcp/compat.c
> >      trunk/reactos/base/services/dhcp/design.txt
> >      trunk/reactos/base/services/dhcp/dhclient.c
> >      trunk/reactos/base/services/dhcp/dhcp.rbuild
> >      trunk/reactos/base/services/dhcp/dhcp.rc
> >      trunk/reactos/base/services/dhcp/dhcpmain.c
> >      trunk/reactos/base/services/dhcp/dispatch.c
> >      trunk/reactos/base/services/dhcp/hash.c
> >      trunk/reactos/base/services/dhcp/include/cdefs.h
> >      trunk/reactos/base/services/dhcp/include/debug.h
> >      trunk/reactos/base/services/dhcp/include/dhcp.h
> >      trunk/reactos/base/services/dhcp/include/dhcpd.h
> >      trunk/reactos/base/services/dhcp/include/dhctoken.h
> >      trunk/reactos/base/services/dhcp/include/hash.h
> >      trunk/reactos/base/services/dhcp/include/inet.h
> >      trunk/reactos/base/services/dhcp/include/osdep.h
> >      trunk/reactos/base/services/dhcp/include/predec.h
> >      trunk/reactos/base/services/dhcp/include/privsep.h
> >      trunk/reactos/base/services/dhcp/include/rosdhcp.h
> >      trunk/reactos/base/services/dhcp/include/site.h
> >      trunk/reactos/base/services/dhcp/include/stdint.h
> >      trunk/reactos/base/services/dhcp/include/sysconf.h
> >      trunk/reactos/base/services/dhcp/include/tree.h
> >      trunk/reactos/base/services/dhcp/include/version.h
> >      trunk/reactos/base/services/dhcp/memory.c
> >      trunk/reactos/base/services/dhcp/options.c
> >      trunk/reactos/base/services/dhcp/pipe.c
> >      trunk/reactos/base/services/dhcp/privsep.c
> >      trunk/reactos/base/services/dhcp/socket.c
> >      trunk/reactos/base/services/dhcp/tables.c
> >      trunk/reactos/base/services/dhcp/timer.c
> >      trunk/reactos/base/services/dhcp/tree.c
> >      trunk/reactos/base/services/dhcp/util.c 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Eric Kohl]

Please keep DHCPCSVC in base\services as this component implements a 
service, and this is also what its name (at least the SVC in DHCSPCSVC) 
implies.


Regards
Eric

Aleksey Bragin wrote:
>   I'm afraid you just deleted all dhcp development
> history. Please revert 
>  these 3 commits and redo them properly using svn copy + svn delete.
>  
>  WBR,
>  Aleksey Bragin.
>  
>  
>  On May 21, 2010, at 9:44 AM, cgutman(a)svn.reactos.org wrote:
>  
> >   Author: cgutman
> >  Date: Fri May 21 07:44:35 2010
> >  New Revision: 47286
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=47286&view=rev
> >  Log:
> >  [DHCP]
> >  - Delete the old dhcp service
> >  - Part 1 of x
> >
> >  Removed:
> >      trunk/reactos/base/services/dhcp/adapter.c
> >      trunk/reactos/base/services/dhcp/alloc.c
> >      trunk/reactos/base/services/dhcp/api.c
> >      trunk/reactos/base/services/dhcp/compat.c
> >      trunk/reactos/base/services/dhcp/design.txt
> >      trunk/reactos/base/services/dhcp/dhclient.c
> >      trunk/reactos/base/services/dhcp/dhcp.rbuild
> >      trunk/reactos/base/services/dhcp/dhcp.rc
> >      trunk/reactos/base/services/dhcp/dhcpmain.c
> >      trunk/reactos/base/services/dhcp/dispatch.c
> >      trunk/reactos/base/services/dhcp/hash.c
> >      trunk/reactos/base/services/dhcp/include/cdefs.h
> >      trunk/reactos/base/services/dhcp/include/debug.h
> >      trunk/reactos/base/services/dhcp/include/dhcp.h
> >      trunk/reactos/base/services/dhcp/include/dhcpd.h
> >      trunk/reactos/base/services/dhcp/include/dhctoken.h
> >      trunk/reactos/base/services/dhcp/include/hash.h
> >      trunk/reactos/base/services/dhcp/include/inet.h
> >      trunk/reactos/base/services/dhcp/include/osdep.h
> >      trunk/reactos/base/services/dhcp/include/predec.h
> >      trunk/reactos/base/services/dhcp/include/privsep.h
> >      trunk/reactos/base/services/dhcp/include/rosdhcp.h
> >      trunk/reactos/base/services/dhcp/include/site.h
> >      trunk/reactos/base/services/dhcp/include/stdint.h
> >      trunk/reactos/base/services/dhcp/include/sysconf.h
> >      trunk/reactos/base/services/dhcp/include/tree.h
> >      trunk/reactos/base/services/dhcp/include/version.h
> >      trunk/reactos/base/services/dhcp/memory.c
> >      trunk/reactos/base/services/dhcp/options.c
> >      trunk/reactos/base/services/dhcp/pipe.c
> >      trunk/reactos/base/services/dhcp/privsep.c
> >      trunk/reactos/base/services/dhcp/socket.c
> >      trunk/reactos/base/services/dhcp/tables.c
> >      trunk/reactos/base/services/dhcp/timer.c
> >      trunk/reactos/base/services/dhcp/tree.c
> >      trunk/reactos/base/services/dhcp/util.c 
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>