Re: [ros-dev] [ros-diffs] [hyperion] 41557: #define inline to __inline for Visual C++ when compiling C sources

[Alex Ionescu]

Why not fix the code instead? I hate these kinds of hacks.

GCC understands __inline and static, so just make the code not use  
STATIC and inline.

On 22-Jun-09, at 1:03 PM, [e-mail] wrote:
> Author: hyperion
> Date: Tue Jun 23 00:03:20 2009
> New Revision: 41557
>
> URL: http://svn.reactos.org/svn/reactos?rev=41557&view=rev
> Log:
> #define inline to __inline for Visual C++ when compiling C sources
>
> Modified:
>    trunk/reactos/ReactOS-generic.rbuild
>
> Modified: trunk/reactos/ReactOS-generic.rbuild
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-generic.rbuild?rev=...
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- trunk/reactos/ReactOS-generic.rbuild [iso-8859-1] (original)
> +++ trunk/reactos/ReactOS-generic.rbuild [iso-8859-1] Tue Jun 23  
> 00:03:20 2009
> @@ -132,6 +132,7 @@
>
>    </group>
>
>    <group compilerset="msc">
> +		<define name="inline" compiler="cc">__inline</define>
>    	<compilerflag>/Zl</compilerflag>
>    	<compilerflag>/Zi</compilerflag>
>    	<compilerflag>/W1</compilerflag>

Best regards,
Alex Ionescu

[KJK::Hyperion]

Alex Ionescu wrote:
> Why not fix the code instead? I hate these kinds of hacks.

Some of the code is not ours, is all. I'll fix what can be fixed, but
there's so much code we get from external sources that will only result
in a mess come merge time