Re: [ros-dev] [ros-diffs] [jgardou] 64911: [USER32] - Fix LookupIconIdFromDirectoryEx, returning 0 when no matching entry is found. - Fix error handling when opening a cursor file. - Various code beautification here and the...

[Thomas Faber]

On 2014-10-23 11:32, jgardou(a)svn.reactos.org wrote:
>   -    if ( dwFileSize < (sizeof(*dir) +
> sizeof(dir->idEntries[0])*(dir->idCount-1)) )
>  +    if (dwFileSize < (sizeof(*dir) + FIELD_OFFSET(CURSORICONFILEDIR,
> idEntries[dir->idCount]))) 
Did you mean to remove the sizeof(*dir)?

[Jérôme Gardou]

Of course.

Le 23/10/2014 14:22, Thomas Faber a écrit :
>   On 2014-10-23 11:32, jgardou(a)svn.reactos.org wrote:
> >   -    if ( dwFileSize < (sizeof(*dir) +
> > sizeof(dir->idEntries[0])*(dir->idCount-1)) )
> >  +    if (dwFileSize < (sizeof(*dir) + FIELD_OFFSET(CURSORICONFILEDIR,
> > idEntries[dir->idCount]))) 
>  
>  Did you mean to remove the sizeof(*dir)?
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>