Re: [ros-dev] [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable.

[Ged]

Did you mean to remove IRP_MJ_CLEANUP?


-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
dgorbachev(a)svn.reactos.org
Sent: 27 May 2009 21:27
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable.

Author: dgorbachev
Date: Thu May 28 00:27:09 2009
New Revision: 41153

URL: http://svn.reactos.org/svn/reactos?rev=41153&view=rev
Log:
Do not assign twice to the same variable.

Modified:
    trunk/reactos/drivers/storage/ide/pciide/pciide.c
    trunk/reactos/ntoskrnl/io/iomgr/rawfs.c

Modified: trunk/reactos/drivers/storage/ide/pciide/pciide.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/pciide…
==============================================================================
--- trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] Thu May 28 00:27:09
2009
@@ -104,7 +104,7 @@
 	ControllerProperties->SupportedTransferMode[0][0] =
 	ControllerProperties->SupportedTransferMode[0][1] =
 	ControllerProperties->SupportedTransferMode[1][0] =
-	ControllerProperties->SupportedTransferMode[1][0] =
+	ControllerProperties->SupportedTransferMode[1][1] =
 		PIO_MODE0 | PIO_MODE1 | PIO_MODE2 | PIO_MODE3 | PIO_MODE4 |
 		SWDMA_MODE0 | SWDMA_MODE1 | SWDMA_MODE2 |
 		MWDMA_MODE0 | MWDMA_MODE1 | MWDMA_MODE2 |

Modified: trunk/reactos/ntoskrnl/io/iomgr/rawfs.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/rawfs.c?…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] Thu May 28 00:27:09 2009
@@ -1082,7 +1082,6 @@
     DriverObject->MajorFunction[IRP_MJ_QUERY_INFORMATION] =
     DriverObject->MajorFunction[IRP_MJ_SET_INFORMATION] =
     DriverObject->MajorFunction[IRP_MJ_QUERY_VOLUME_INFORMATION] =
-    DriverObject->MajorFunction[IRP_MJ_CLEANUP] =
     DriverObject->MajorFunction[IRP_MJ_FILE_SYSTEM_CONTROL] =
     DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] =
(PDRIVER_DISPATCH)RawDispatch;

[Dmitry Gorbachev]

Ged writes:

>   Did you mean to remove IRP_MJ_CLEANUP? 
There are 10 functions in RawDispatch(), 11th in RawFsDriverEntry() is 
probably superfluous. Or some function is forgotten in RawDispatch().