This is a full implementation of the regedit search function. :D English and German language available, with other languages the "Find" and "Find next" menu points are still disabled.
Come, get some!! :) :)
Greetings, Jan Schiefer!
From: Jan Schiefer
This is a full implementation of the regedit search function.
I haven't dug too deep, but there seems to be a memory overwrite somewhere. When searching for an existing key name under ReactOS, regedit crashes when the key is found. Under Windows, it crashes when I exit regedit.
:D English and German language available, with other languages the "Find" and "Find next" menu points are still disabled.
Any reason why we shouldn't enable "Find" for other languages?
Gé van Geldorp.
Ge van Geldorp schrieb:
From: Jan Schiefer
This is a full implementation of the regedit search function.
I haven't dug too deep, but there seems to be a memory overwrite somewhere. When searching for an existing key name under ReactOS, regedit crashes when the key is found. Under Windows, it crashes when I exit regedit.
It works for me under Wine. Ill have to test it under Windows again.
:D English and German language available, with other languages the "Find" and "Find next" menu points are still disabled.
Any reason why we shouldn't enable "Find" for other languages?
Ok, I could put english stuff in the .rc files.
Gé van Geldorp.
From: Jan Schiefer
Ge van Geldorp schrieb:
somewhere. When searching for an existing key name under ReactOS, regedit crashes when the key is found. Under Windows, it crashes when I exit regedit.
It works for me under Wine. Ill have to test it under Windows again.
Ok, thanks, if you can't reproduce the problem let me know and I'll take a look again.
Any reason why we shouldn't enable "Find" for other languages?
Ok, I could put english stuff in the .rc files.
Actually, the resource loading code will load the English version of a resource if it can't find the correct language, so there's no need to duplicate the English stuff in other .rc files.
Gé van Geldorp.
Ok, thanks, if you can't reproduce the problem let me know and I'll take a look again.
Do you have any output in the console before it happens. Like "Searching for xxx..." or "xxx results."?
Actually, the resource loading code will load the English version of a resource if it can't find the correct language, so there's no need to duplicate the English stuff in other .rc files.
I don't know hot to do that with dialogs. With messageboxes it's no problem.
From: Jan Schiefer
Do you have any output in the console before it happens. Like "Searching for xxx..." or "xxx results."?
I search for ".cpl", get the Search dialog box with the text "Registry is being searched...", wait some time, wait some more, and then it crashes. Stack backtrace is different each time.
Actually, the resource loading code will load the English version of a resource if it can't find the correct language, so there's no need to duplicate the English stuff in other .rc files.
I don't know hot to do that with dialogs. With messageboxes it's no problem.
What I was trying to say is that you don't have to add the new English resources to e.g. Nl.rc when you remove GRAYED from the ID_EDIT_FIND line.
Gé van Geldorp.
Ge van Geldorp schrieb:
From: Jan Schiefer
Do you have any output in the console before it happens. Like "Searching for xxx..." or "xxx results."?
I search for ".cpl", get the Search dialog box with the text "Registry is being searched...", wait some time, wait some more, and then it crashes. Stack backtrace is different each time.
Actually, the resource loading code will load the English version of a resource if it can't find the correct language, so there's no need to duplicate the English stuff in other .rc files.
I don't know hot to do that with dialogs. With messageboxes it's no problem.
What I was trying to say is that you don't have to add the new English resources to e.g. Nl.rc when you remove GRAYED from the ID_EDIT_FIND line.
Gé van Geldorp.
What the?!?! After updateing to newest SVN regedit even fails to start!! With wine I get "Unimpleneted function kernel32.dll.Rtl.Allocate.Heap"
Applied any patches???
-
Ge van Geldorp -
Jan Schiefer