Re: [ros-dev] Ros-diffs Digest, Vol 146, Issue 58

[Hermès BÉLUSCA - MAÏTO]

This is indeed an amazing feature, until you notice that you've tested
already local build compilation (just before committing) and neither GCC nor
MSVC detected any error, and only after commit you see that it breaks the
build bots...

Hermès.

-----Message d'origine-----
Date: Thu, 17 Mar 2016 07:55:00 -0000
From: [e-mail]
To: [e-mail]
Subject: [ros-diffs] [pschweitzer] 71017: [VFATLIB] Hint for future
    and current developers: there's a hidden feature in ReactOS, you can
    build it locally before committing, so that you can check whether
your
    commit bre...
Message-ID: [e-mail]
Content-Type: text/plain; charset="utf-8"

Author: pschweitzer
Date: Thu Mar 17 07:55:00 2016
New Revision: 71017

URL: http://svn.reactos.org/svn/reactos?rev=71017&view=rev
Log:
[VFATLIB]
Hint for future and current developers: there's a hidden feature in ReactOS,
you can build it locally before committing, so that you can check whether
your commit breaks build...
Amazing, isn't it?

Modified:
    trunk/reactos/lib/fslib/vfatlib/check/common.h

Modified: trunk/reactos/lib/fslib/vfatlib/check/common.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fslib/vfatlib/check/com
mon.h?rev=71017&r1=71016&r2=71017&view=diff
============================================================================
==
--- trunk/reactos/lib/fslib/vfatlib/check/common.h	[iso-8859-1]
(original)
+++ trunk/reactos/lib/fslib/vfatlib/check/common.h	[iso-8859-1] Thu Mar
17 07:55:00 2016
@@ -32,7 +32,7 @@
 void die_func(const char *msg, ...);
 #define die(msg, ...)   \
 do {                    \
-    die_func("DIE! (%s:%d) " msg "\n", __RELFILE__, __LINE__,
##__VA_ARGS__)  \
+    die_func("DIE! (%s:%d) " msg "\n", __RELFILE__, __LINE__, 
+ ##__VA_ARGS__);  \
 } while (0)

/* Displays a prinf-style message and terminates the program. */ @@ -42,7
+42,7 @@  void pdie_func(const char *msg, ...);
 #define pdie(msg, ...)   \
 do {                    \
-    pdie_func("P-DIE! (%s:%d) " msg "\n", __RELFILE__, __LINE__,
##__VA_ARGS__)  \
+    pdie_func("P-DIE! (%s:%d) " msg "\n", __RELFILE__, __LINE__, 
+ ##__VA_ARGS__);  \
 } while (0)

/* Like die, but appends an error message according to the state of errno.
*/

------------------------------

Subject: Digest Footer

_______________________________________________
Ros-diffs mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-diffs

------------------------------

End of Ros-diffs Digest, Vol 146, Issue 58
******************************************