Re: [ros-svn] [navaraf] 13369: Force non-inlining of ctype functions even in OPTIMIZED builds. Fixes bug #497.

[Alex Ionescu]

[e-mail] wrote:
> Force non-inlining of ctype functions even in OPTIMIZED builds. Fixes bug #497.
>
> Updated files:
> trunk/reactos/lib/kjs/makefile
>
> Ros-svn mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-svn

Aren't you forcing non-inlining of EVERY function by doing this? Isn't 
it better to enable the special no ctype inline macro?

Best regards,
Alex Ionescu

[Filip Navara]

Alex Ionescu wrote:
> Aren't you forcing non-inlining of EVERY function by doing this? Isn't 
> it better to enable the special no ctype inline macro?

Actually there are only two instances of this macro in the headers, both 
protecting the CTYPE inline prototypes. I think it's safer to use this 
macro instead of __NO_CTYPE_INLINES since we don't ANY of the "CRT" 
functions to be inlined.

- Filip

[Alex Ionescu]

Filip Navara wrote:
> Alex Ionescu wrote:
> > Aren't you forcing non-inlining of EVERY function by doing this? 
> > Isn't it better to enable the special no ctype inline macro?
>
> Actually there are only two instances of this macro in the headers, 
> both protecting the CTYPE inline prototypes. I think it's safer to use 
> this macro instead of __NO_CTYPE_INLINES since we don't ANY of the 
> "CRT" functions to be inlined.
> Filip

Oh all right... just making sure it was the right thing to do! Thanks.

Best regards,
Alex Ionescu