Re: [ros-dev] [ros-diffs] [greatlrd] 28055: user32 cleanup lite redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file nci tools changes (done of timo and me) frist part moving the w32ksvc.db and sysfuncs.lst where they belong

[Steven Edwards]

On 7/31/07, greatlrd(a)svn.reactos.org <greatlrd(a)svn.reactos.org> wrote:
>   user32 cleanup lite
>  redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file 
>   Modified:
>      trunk/reactos/dll/win32/user32/controls/button.c
>      trunk/reactos/dll/win32/user32/controls/combo.c 
Is it really worth the merge hassle to change it in these two files?
They are almost 100% shared with Wine and I doubt the overhead in
calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on
whoever the maintainer is going to be....

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Thomas Weidenmueller]

No it's not worth the hazzle because those changes result in *NO*
optimizations anyway. The code that was changed were calls to
InvalidateRect to NtUserInvalidateRect. Since InvalidateRect is already
forwarded to NtUserInvalidateRect this doesn't really improve anything,
it's the same overhead. These changes should be reverted, not just
because it makes no sense to optimize these function calls even more
because they're absolutely not time-critical.

Please revert.

- Thomas

Steven Edwards wrote:
>   On 7/31/07, greatlrd(a)svn.reactos.org
> <greatlrd(a)svn.reactos.org> wrote:
> >   user32 cleanup lite
> >  redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file 
>  
> >   Modified:
> >      trunk/reactos/dll/win32/user32/controls/button.c
> >      trunk/reactos/dll/win32/user32/controls/combo.c 
>  
>  Is it really worth the merge hassle to change it in these two files?
>  They are almost 100% shared with Wine and I doubt the overhead in
>  calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on
>  whoever the maintainer is going to be....
>

[James Tabor]

Steven Edwards wrote:
>   On 7/31/07, greatlrd(a)svn.reactos.org
> <greatlrd(a)svn.reactos.org> wrote:
> >   user32 cleanup lite
> >  redirect the InvalidateRect@12 to NtUserInvalidateRect@12 in the def file 
>  
> >   Modified:
> >      trunk/reactos/dll/win32/user32/controls/button.c
> >      trunk/reactos/dll/win32/user32/controls/combo.c 
>  
>  Is it really worth the merge hassle to change it in these two files?
>  They are almost 100% shared with Wine and I doubt the overhead in
>  calling InvalidateRect vs NtUserInvalidateRect is worth the hassle on
>  whoever the maintainer is going to be....
>   
Hi Steven!
Man! You are right! The newbies are creating more work for me at every
turn! I wish they would stop committing on crack!

Thank you for the extra work!
James

[Ged]

James Tabor wrote:
>   Man! You are right! The newbies are creating more work
> for me at every
>  turn! I wish they would stop committing on crack!
>
>  Thank you for the extra work!
>     
That's rather harsh and partonising!
These so called 'newbies' have done a great deal of good work recently.