New subject: [ros-diffs] [hbelusca] 62140: [REACTOS] Go fully to Win2k3 SP2 version reporting. CORE-6611 #resolve #comment Fixed in r62140.

12 Feb 2014

I am so sick of these types of changes being made without consultation.

The kernel is not SP2. Please do not update this value, as we are
missing exports/functionality exposed on SP2.
Best regards,
Alex Ionescu

On Wed, Feb 12, 2014 at 12:03 PM,  &lt;hbelusca(a)svn.reactos.org&gt; wrote:
...
  Author: hbelusca
 Date: Wed Feb 12 20:03:57 2014
 New Revision: 62140

 URL: http://svn.reactos.org/svn/reactos?rev=62140&view=rev
 Log:
 [REACTOS]
 Go fully to Win2k3 SP2 version reporting.
 CORE-6611 #resolve #comment Fixed in r62140.

 Modified:
     trunk/reactos/boot/bootdata/hivesys.inf
     trunk/reactos/include/psdk/ntverp.h
     trunk/reactos/ntoskrnl/ex/init.c

 Modified: trunk/reactos/boot/bootdata/hivesys.inf
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?…
 ==============================================================================
 --- trunk/reactos/boot/bootdata/hivesys.inf     [iso-8859-1] (original)
 +++ trunk/reactos/boot/bootdata/hivesys.inf     [iso-8859-1] Wed Feb 12 20:03:57 2014
 @@ -1143,8 +1143,8 @@
  ; ReactOS specific - by default we report ourselves as Server for the user,
  ; but we can also report as Workstation if some application needs it.

HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000
 -; Some installers check for SP1

-HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000100
 +; Some installers check for SP2

+HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200

HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll"

HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012

 Modified: trunk/reactos/include/psdk/ntverp.h
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=…
 ==============================================================================
 --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original)
 +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 20:03:57 2014
 @@ -14,10 +14,10 @@
   */

  //
 -// Windows NT Build 3790.1830
 +// Windows NT Build 3790.3959
  //
  #define VER_PRODUCTBUILD                    3790
 -#define VER_PRODUCTBUILD_QFE                1830
 +#define VER_PRODUCTBUILD_QFE                3959

  //
  // Windows NT Version 5.2

 Modified: trunk/reactos/ntoskrnl/ex/init.c
 URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=621…
 ==============================================================================
 --- trunk/reactos/ntoskrnl/ex/init.c    [iso-8859-1] (original)
 +++ trunk/reactos/ntoskrnl/ex/init.c    [iso-8859-1] Wed Feb 12 20:03:57 2014
 @@ -1072,12 +1072,12 @@
      /* Setup initial system settings */
      CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector);

 -    /* Load static defaults for Service Pack 1 and add our SVN revision */
 +    /* Load static defaults for Service Pack 2 and add our SVN revision */
      /* Format of CSD : SPMajor - SPMinor */
 -    CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16);
 +    CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16);
      CmNtCSDReleaseType = 0;

 -    /* Set Service Pack data for Service Pack 1 */
 +    /* Set Service Pack data for Service Pack 2 */
      CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE;
      if (!(CmNtCSDVersion & 0xFFFF0000))
      {

Re: [ros-dev] [ros-diffs] [hbelusca] 62140: [REACTOS] Go fully to Win2k3 SP2 version reporting. CORE-6611 #resolve #comment Fixed in r62140.