Application Regression (vim.exe)

[WaxDragon]

Devs,

I installed the win32 vim package from vim.org back around
0.2.3-0.2.4, and was quite surprised when the console vim.exe mostly
worked.  Recently, while testing PuTTY, I tried the command line tools
(psftp specifically) and they would not accept input.  I could ^C out
of it and then all the input I had typed showed up on the command
line.  So, I tried the console vim again and it doesn't accept input
also.   I checked both vim.exe and the command line putty tools under
0.2.4 and 0.2.5-rc2, and they both work, so it is something after the
0.2.5 branch.

I'm reporting this to the ML because I'm not very familiar with
the console code.  Any ideas or pointers would be appreciated.

Andy
-- 
The cheese stands alone.

[Gunnar Dalsnes]

rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss 
(ReadConsole, line input). i'm looking into it, but can't promise anything

Gunnar

WaxDragon wrote:
> Devs,
> I installed the win32 vim package from vim.org back around
>
> 0.2.3-0.2.4, and was quite surprised when the console vim.exe mostly
> worked.  Recently, while testing PuTTY, I tried the command line tools
> (psftp specifically) and they would not accept input.  I could ^C out
> of it and then all the input I had typed showed up on the command
> line.  So, I tried the console vim again and it doesn't accept input
> also.   I checked both vim.exe and the command line putty tools under
> 0.2.4 and 0.2.5-rc2, and they both work, so it is something after the
> 0.2.5 branch.
> I'm reporting this to the ML because I'm not very familiar with
>
> the console code.  Any ideas or pointers would be appreciated.
>
> Andy

[Ge van Geldorp]

> From: Gunnar Dalsnes
>
> rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss 
> (ReadConsole, line input). i'm looking into it, but can't 
> promise anything

Sorry for breaking it, I've reversed my change for now. The change was
introduced because PuTTy would see both key down and key up as an input
event, so every letter you typed would be doubled. I'll find another way to
fix it.

Gé van Geldorp.

[Gunnar Dalsnes]

Ge van Geldorp wrote:
> > From: Gunnar Dalsnes
> >
> > rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss 
> > (ReadConsole, line input). i'm looking into it, but can't 
> > promise anything
>
> Sorry for breaking it, I've reversed my change for now. The change was
> introduced because PuTTy would see both key down and key up as an input
> event, so every letter you typed would be doubled. I'll find another way to
> fix it.

Your fix might be correct and csrss might be the one that needs fixing. 
In this case, finding another way to fix it migth break something else:-)

Gunnar
> Gé van Geldorp.
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[art yerkes]

On Mon, 3 Jan 2005 23:04:30 +0100
"Ge van Geldorp" [e-mail] wrote:
> > From: Gunnar Dalsnes
> >
> > rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss 
> > (ReadConsole, line input). i'm looking into it, but can't 
> > promise anything
>
> Sorry for breaking it, I've reversed my change for now. The change was
> introduced because PuTTy would see both key down and key up as an input
> event, so every letter you typed would be doubled. I'll find another way to
> fix it.

Down and up should both be input events but only one should generate a char
readable by ReadFile.  Both will generate events readable by ReadConsoleInput.
Perhaps we're not marking keyup correctly.
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Ge van Geldorp]

> From: Ge van Geldorp
> > From: Gunnar Dalsnes
> >
> > rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss
> > (ReadConsole, line input). i'm looking into it, but can't 
> > promise anything
>
> Sorry for breaking it, I've reversed my change for now. The 
> change was introduced because PuTTy would see both key down 
> and key up as an input event, so every letter you typed would 
> be doubled. I'll find another way to fix it.

The attached patch makes both PuTTy and ReadConsole (line input) happy.
Psftp doesn't work, but that seems to be related to networking stuff, not
(anymore) to ReadConsole.

I'd appreciate it if you guys could test the patch.

Gé van Geldorp.

[WaxDragon]

Thanks Gé!

After applying this patch on 12838, both putty and psftp work, but vim
still doesn't.  This is a new combination.

On Wed, 5 Jan 2005 20:20:09 +0100, Ge van Geldorp [e-mail] wrote:
> > From: Ge van Geldorp
> > > From: Gunnar Dalsnes
> > >
> > > rev. 12374 (reactos/subsys/win32k/ntuser/keyboard.c) broke csrss
> > > (ReadConsole, line input). i'm looking into it, but can't
> > > promise anything
> >
> > Sorry for breaking it, I've reversed my change for now. The
> > change was introduced because PuTTy would see both key down
> > and key up as an input event, so every letter you typed would
> > be doubled. I'll find another way to fix it.
>
> The attached patch makes both PuTTy and ReadConsole (line input) happy.
> Psftp doesn't work, but that seems to be related to networking stuff, not
> (anymore) to ReadConsole.
>
> I'd appreciate it if you guys could test the patch.
>
> Gé van Geldorp.
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev
-- 
The cheese stands alone.

[Ge van Geldorp]

> From: WaxDragon
>
> After applying this patch on 12838, both putty and psftp 
> work, but vim still doesn't.  This is a new combination.

Vim not working was due to a completely unrelated bug in
lib/user32/windows/message.c. Fixed in r12850.

Gé van Geldorp.