Re: [ros-dev] [ros-diffs] [jimtabor] 33965: Patch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong place.

[gedmurphy]

Did this glitch appear in windows too?
I don't remember seeing this, and I have a feeling this patch is hiding an underlying
bug.

Ged.

-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
jimtabor(a)svn.reactos.org
Sent: 14 June 2008 18:11
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [jimtabor] 33965: Patch by carlo bramix at libero dot it: Bug 3336
statusbar in the wrong place.

Author: jimtabor
Date: Sat Jun 14 12:10:55 2008
New Revision: 33965

URL: http://svn.reactos.org/svn/reactos?rev=33965&view=rev
Log:
Patch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong place.

Modified:
    trunk/reactos/base/applications/games/solitaire/solitaire.cpp

Modified: trunk/reactos/base/applications/games/solitaire/solitaire.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/so…
==============================================================================
--- trunk/reactos/base/applications/games/solitaire/solitaire.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/games/solitaire/solitaire.cpp [iso-8859-1] Sat Jun 14
12:10:55 2008
@@ -496,6 +496,7 @@
             {
                 MoveWindow(SolWnd, 0, 0, nWidth, nHeight - nStatusHeight, TRUE);
                 MoveWindow(hwndStatus, 0, nHeight - nStatusHeight, nWidth, nHeight,
TRUE);
+                SendMessage(hwndStatus, WM_SIZE, wParam, lParam);
             }
             else
             {

[Timo Kreuzer]

It's defenately hiding an underlying bug.

On windows the statusbar is not shown when it's not selected in the 
options, minimizing and restoring doesn't change that.

For more info see
http://www.reactos.org/bugzilla/show_bug.cgi?id=3336


gedmurphy schrieb:
>   Did this glitch appear in windows too?
>  I don't remember seeing this, and I have a feeling this patch is hiding an underlying
> bug.
>
>  Ged.
>
>  -----Original Message-----
>  From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
> jimtabor(a)svn.reactos.org
>  Sent: 14 June 2008 18:11
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [jimtabor] 33965: Patch by carlo bramix at libero dot it: Bug 3336
> statusbar in the wrong place.
>
>  Author: jimtabor
>  Date: Sat Jun 14 12:10:55 2008
>  New Revision: 33965
>
>  URL: http://svn.reactos.org/svn/reactos?rev=33965&view=rev
>  Log:
>  Patch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong place.
>
>  Modified:
>      trunk/reactos/base/applications/games/solitaire/solitaire.cpp
>
>  Modified: trunk/reactos/base/applications/games/solitaire/solitaire.cpp
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/so…
>  ==============================================================================
>  --- trunk/reactos/base/applications/games/solitaire/solitaire.cpp [iso-8859-1]
> (original)
>  +++ trunk/reactos/base/applications/games/solitaire/solitaire.cpp [iso-8859-1] Sat Jun 14
> 12:10:55 2008
>  @@ -496,6 +496,7 @@
>               {
>                   MoveWindow(SolWnd, 0, 0, nWidth, nHeight - nStatusHeight, TRUE);
>                   MoveWindow(hwndStatus, 0, nHeight - nStatusHeight, nWidth, nHeight,
> TRUE);
>  +                SendMessage(hwndStatus, WM_SIZE, wParam, lParam);
>               }
>               else
>               {
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>

[gedmurphy]

Just to note, I wasn't saying the patch supplied by Carlo was wrong, it was
definitely right!
I just didn't want the application of this patch to hide an underlying GDI
bug.
However, James left the bug open. I hadn't realised at the time of my
original email.

Ged.

-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Timo Kreuzer
Sent: 14 June 2008 22:42
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [jimtabor] 33965: Patch by carlo bramix
at libero dot it: Bug 3336 statusbar in the wrong place.

It's defenately hiding an underlying bug.

On windows the statusbar is not shown when it's not selected in the 
options, minimizing and restoring doesn't change that.

For more info see
http://www.reactos.org/bugzilla/show_bug.cgi?id=3336


gedmurphy schrieb:
>   Did this glitch appear in windows too?
>  I don't remember seeing this, and I have a feeling this patch is hiding an
underlying bug.
>  
>  Ged.
>
>  -----Original Message-----
>  From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] 
On
Behalf Of jimtabor(a)svn.reactos.org
>   Sent: 14 June 2008 18:11
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [jimtabor] 33965: Patch by carlo bramix at libero dot 
it: Bug
3336 statusbar in the wrong place.
>  
>  Author: jimtabor
>  Date: Sat Jun 14 12:10:55 2008
>  New Revision: 33965
>
>  URL: http://svn.reactos.org/svn/reactos?rev=33965&view=rev
>  Log:
>  Patch by carlo bramix at libero dot it: Bug 3336 statusbar in the wrong 
place.
>  
>  Modified:
>      trunk/reactos/base/applications/games/solitaire/solitaire.cpp
>
>  Modified: trunk/reactos/base/applications/games/solitaire/solitaire.cpp
>  URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol
itaire/solitaire.cpp?rev=33965&r1=33964&r2=33965&view=diff
>  
============================================================================
==
>   ---
> trunk/reactos/base/applications/games/solitaire/solitaire.cpp 
[iso-8859-1]
(original)
>   +++
> trunk/reactos/base/applications/games/solitaire/solitaire.cpp 
[iso-8859-1] Sat Jun
14 12:10:55 2008
>   @@ -496,6 +496,7 @@
>               {
>                   MoveWindow(SolWnd, 0, 0, nWidth, nHeight - nStatusHeight, 
TRUE);
>                    MoveWindow(hwndStatus, 0, nHeight -
> nStatusHeight, 
nWidth, nHeight, TRUE);
> +                SendMessage(hwndStatus, WM_SIZE, wParam, lParam);
>              }
>              else
>              {
>   
>  
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>   
>   

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev