Re: [ros-dev] [ros-diffs] [cgutman] 41090: - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions - Sorry for so many commits on the same function

[Alex Ionescu]

May I ask, why not use simple C for this?:

DriverBlock->DriverObject->MajorFunction = MajorFunctions;

Or if that doesn't work, use a casting trick...

Best regards,
Alex Ionescu

On Sun, May 24, 2009 at 2:49 AM,  [e-mail] wrote:
> Author: cgutman
> Date: Sun May 24 04:49:02 2009
> New Revision: 41090
>
> URL: http://svn.reactos.org/svn/reactos?rev=41090&view=rev
> Log:
>  - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions
>  - Sorry for so many commits on the same function
>
> Modified:
>    trunk/reactos/drivers/network/ndis/ndis/miniport.c
>
> Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/m...
> ==============================================================================
> --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original)
> +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Sun May 24 04:49:02 2009
> @@ -2788,7 +2788,7 @@
>         return NDIS_STATUS_RESOURCES;
>     }
> for (i = 0; i < IRP_MJ_MAXIMUM_FUNCTION; i++)
> for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++)
>
> DriverBlock->DriverObject->MajorFunction[i] = MajorFunctions[i];
>
> DriverBlock->DriverObject->MajorFunction[IRP_MJ_PNP] = NdisIDispatchPnp;

[Alexander Potashev]

2009/5/24 Alex Ionescu [e-mail]:
> May I ask, why not use simple C for this?:
>
> DriverBlock->DriverObject->MajorFunction = MajorFunctions;

This won't work.
Btw, this line is indented with 5 spaces O_O
> Or if that doesn't work, use a casting trick...

What do you mean? casting to a bogus structure of size
sizeof(PDRIVER_DISPATCH)*IRP_MJ_MAXIMUM_FUNCTION ?

Alexander