Re: [ros-dev] [ros-diffs] [akhaldi] 65617: [USER32] We're not using any debugging routines here.

[Timo Kreuzer]

Honestly, I don't see any point in these modifications. The next time 
someone wants to use these debug routines, he will need to add it back. 
Or he will start using DPRINT stuff again. I'd prefer to have this in 
all files!

Am 12.12.2014 14:23, schrieb akhaldi(a)svn.reactos.org:
>   Author: akhaldi
>  Date: Fri Dec 12 13:23:45 2014
>  New Revision: 65617
>
>  URL: http://svn.reactos.org/svn/reactos?rev=65617&view=rev
>  Log:
>  [USER32] We're not using any debugging routines here.
>
>  Modified:
>       trunk/reactos/win32ss/user/user32/misc/rtlstr.c
>
>  Modified: trunk/reactos/win32ss/user/user32/misc/rtlstr.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/r…
>  ==============================================================================
>  --- trunk/reactos/win32ss/user/user32/misc/rtlstr.c	[iso-8859-1] (original)
>  +++ trunk/reactos/win32ss/user/user32/misc/rtlstr.c	[iso-8859-1] Fri Dec 12 13:23:45
> 2014
>  @@ -10,10 +10,6 @@
>    /* INCLUDES ******************************************************************/
>    
>    #include <user32.h>
>  -
>  -#include <wine/debug.h>
>  -
>  -WINE_DEFAULT_DEBUG_CHANNEL(user32);
>    
>    /* FUNCTIONS *****************************************************************/
>    VOID
>
>
>

[Amine Khaldi]

>   Honestly, I don't see any point in these
> modifications. The next time someone wants to use these debug routines, he will need to
> add it back. Or he will start using DPRINT stuff again. I'd prefer to have this in all
> files!  
Clang emits warnings because of them, and having includes that we don't use
doesn't make sense (we can also use this argument to include unneeded headers right
now simply because we may need them in the future).

There are tools to perform the exact opposite pattern
(http://code.google.com/p/include-what-you-use/ https://code.google.com/p/uninclude/ and
co)

Please note that these inclusions are being removed in *most* of our codebase through Wine
(http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=commit&am…)

When someone revisits this code and needs to add debug routines, then he'll simply
have to include the relevant header. If he starts using DPRINT stuff *then* you may issue
an email advising *him* not to.