Re: [ros-dev] [ros-diffs] [dreimer] 45286: - Add piperead to the setup. - Update ChangeLog.txt - Sync clean.ps1 to Colin's changes.

[Colin Finck]

[e-mail] wrote:
> if ("$ENV:ROS_AUTOMAKE" -eq "") {
>    $ENV:ROS_AUTOMAKE = "makefile-$ENV:ROS_ARCH.auto"
> }
>
> [...]

That's not properly ported.
My script only sets these variables locally due to "setlocal", yours
permanently changes the environment variables. This will result in obvious
problems when ROS_ARCH is changed.

Don't know whether PS provides an equally elegant way to overwrite these
variables locally like Batch does ;-)

Best regards,

Colin

[Daniel Reimer]

Oh, right. Yes, it does, one second.

Btw, GCC 4.4.3 fails badly on makex....

Colin Finck schrieb:
> [e-mail] wrote:
> > if ("$ENV:ROS_AUTOMAKE" -eq "") {
> >    $ENV:ROS_AUTOMAKE = "makefile-$ENV:ROS_ARCH.auto"
> > }
> >
> > [...]
>
> That's not properly ported.
> My script only sets these variables locally due to "setlocal", yours
> permanently changes the environment variables. This will result in obvious
> problems when ROS_ARCH is changed.
>
> Don't know whether PS provides an equally elegant way to overwrite these
> variables locally like Batch does ;-)
>
> Best regards,
>
> Colin
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Daniel Reimer]

Hi, I'd like to know if its just me or GCC 4.4.3 fails in makex or make 
with Colin's recent Patch.

when I type make bootcd I get
make.exe: *** No rule to make target `bootcd'.  Stop.

and with just make I get
make.exe: Nothing to be done for `all'.

Same happens when I bypass the make Script by typing make.exe.

Err.... HELP?

[Colin Finck]

Daniel Reimer wrote:
> Hi, I'd like to know if its just me or GCC 4.4.3 fails in 
> makex or make with Colin's recent Patch.

Yes, that's indeed a bug, which has been fixed in version 7 of the patch:
http://www.reactos.org/bugzilla/show_bug.cgi?id=4810#c21

Best regards,

Colin