Re: [ros-dev] [ros-diffs] [pschweitzer] 52065: [NTOSKRNL] - renamed Io volumes global to match Windows names (in case of debug) - renamed IopDereferenceVpb() to IopDereferenceVpbAndFree(), IopReferenceVpbForVerify() to IopR...

[Alex Ionescu]

Same comment as before, resources MUST be acquired within a critical region (as the old code did).

--
Best regards,
Alex Ionescu

On 2011-06-02, at 1:43 PM, [e-mail] wrote:
> /* Acquire the FS lock */
> KeEnterCriticalRegion();
> ExAcquireResourceExclusiveLite(&FileSystemListLock, TRUE);
> ExAcquireResourceExclusiveLite(&IopDatabaseResource, TRUE);

[Javier Agustìn Fernàndez Arroyo]

i love the way you talk with yourself :P

On Thu, Jun 2, 2011 at 8:02 PM, Alex Ionescu [e-mail] wrote:
> Same comment as before, resources MUST be acquired within a critical region
> (as the old code did).
>
> --
> Best regards,
> Alex Ionescu
>
> On 2011-06-02, at 1:43 PM, [e-mail] wrote:
> > /* Acquire the FS lock */
> > KeEnterCriticalRegion();
> > ExAcquireResourceExclusiveLite(&FileSystemListLock, TRUE);
> > ExAcquireResourceExclusiveLite(&IopDatabaseResource, TRUE);
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Olaf Siejka]

He is reviewing the bloody code, Javier.

2011/6/2 Javier Agustìn Fernàndez Arroyo [e-mail]
> i love the way you talk with yourself :P
>
> On Thu, Jun 2, 2011 at 8:02 PM, Alex Ionescu [e-mail] wrote:
> > Same comment as before, resources MUST be acquired within a critical
> > region (as the old code did).
> >
> > --
> > Best regards,
> > Alex Ionescu
> >
> > On 2011-06-02, at 1:43 PM, [e-mail] wrote:
> > > /* Acquire the FS lock */
> > > KeEnterCriticalRegion();
> > > ExAcquireResourceExclusiveLite(&FileSystemListLock, TRUE);
> > > ExAcquireResourceExclusiveLite(&IopDatabaseResource, TRUE);
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Ged Murphy]

Do you even understand what he’s ‘talking to himself’ about?

Perhaps you should refrain from commenting until you do.

From: [e-mail] [mailto:[e-mail]] On
Behalf Of Javier Agustìn Fernàndez Arroyo
Sent: 02 June 2011 20:18
To: ReactOS Development List
Cc: [e-mail]
Subject: Re: [ros-dev] [ros-diffs] [pschweitzer] 52065: [NTOSKRNL] - renamed
Io volumes global to match Windows names (in case of debug) - renamed
IopDereferenceVpb() to IopDereferenceVpbAndFree(),
IopReferenceVpbForVerify() to IopR...

i love the way you talk with yourself :P

On Thu, Jun 2, 2011 at 8:02 PM, Alex Ionescu [e-mail] wrote:

Same comment as before, resources MUST be acquired within a critical region
(as the old code did).

--
Best regards,
Alex Ionescu

On 2011-06-02, at 1:43 PM, [e-mail] wrote:
> /* Acquire the FS lock */
> KeEnterCriticalRegion();
> ExAcquireResourceExclusiveLite(&FileSystemListLock, TRUE);
> ExAcquireResourceExclusiveLite(&IopDatabaseResource, TRUE);

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev