Re: [ros-dev] [ros-diffs] 01/01: [HAL] Remove misleading debug prints about USB controllers.

[Alex Ionescu]

Why are these misleading? These are checks that Windows does that we are
missing.

Guys, open PRs for changes like these ffs.

Best regards,
Alex Ionescu


On Wed, Aug 8, 2018 at 7:14 PM Thomas Faber <thomas.faber(a)reactos.org>
wrote:

>  
>
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1ed0f9ab576f094b27e11…
>
>  commit 1ed0f9ab576f094b27e11ba374738ecabc00e2e6
>  Author:     Thomas Faber <thomas.faber(a)reactos.org>
>  AuthorDate: Wed Aug 8 19:58:56 2018 +0200
>  Commit:     Thomas Faber <thomas.faber(a)reactos.org>
>  CommitDate: Wed Aug 8 20:08:38 2018 +0200
>
>      [HAL] Remove misleading debug prints about USB controllers.
>  ---
>   hal/halx86/legacy/bussupp.c | 26 --------------------------
>   1 file changed, 26 deletions(-)
>
>  diff --git a/hal/halx86/legacy/bussupp.c b/hal/halx86/legacy/bussupp.c
>  index a37d875ede..4d20396560 100644
>  --- a/hal/halx86/legacy/bussupp.c
>  +++ b/hal/halx86/legacy/bussupp.c
>  @@ -1128,32 +1128,6 @@ HalpInitializePciBus(VOID)
>                       }
>                   }
>
>  -                /* Check if this is a USB controller */
>  -                if ((PciData->BaseClass == PCI_CLASS_SERIAL_BUS_CTLR) &&
>  -                    (PciData->SubClass == PCI_SUBCLASS_SB_USB))
>  -                {
>  -                    /* Check if this is an OHCI controller */
>  -                    if (PciData->ProgIf == 0x10)
>  -                    {
>  -                        DbgPrint("\tDevice is an OHCI (USB) PCI Expansion
>  Card. Turn off Legacy USB in your BIOS!\n\n");
>  -                        continue;
>  -                    }
>  -
>  -                    /* Check for Intel UHCI controller */
>  -                    if (PciData->VendorID == 0x8086)
>  -                    {
>  -                        DbgPrint("\tDevice is an Intel UHCI (USB)
>  Controller. Turn off Legacy USB in your BIOS!\n\n");
>  -                        continue;
>  -                    }
>  -
>  -                    /* Check for VIA UHCI controller */
>  -                    if (PciData->VendorID == 0x1106)
>  -                    {
>  -                        DbgPrint("\tDevice is a VIA UHCI (USB)
>  Controller. Turn off Legacy USB in your BIOS!\n\n");
>  -                        continue;
>  -                    }
>  -                }
>  -
>                   /* Now check the registry for chipset hacks */
>                   Status = HalpGetChipHacks(PciData->VendorID,
>                                             PciData->DeviceID,
>
>