Re: [ros-dev] [ros-diffs] [cgutman] 52522: [LDR] - "Just to be sure" is no reason to overwrite a potential DLL load failure status

[Aleksey Bragin]

That was there on purpose really, because the error had to be ignored. I 
will get back to this tomorrow to review, so just "marking" this revision 
that way.

WBR,
Aleksey.

-----Original Message----- 
From: [e-mail]
Sent: Monday, July 04, 2011 12:16 AM
To: [e-mail]
Subject: [ros-diffs] [cgutman] 52522: [LDR] - "Just to be sure" is no reason 
to overwrite a potential DLL load failure status

Author: cgutman
Date: Sun Jul  3 20:16:12 2011
New Revision: 52522

URL: http://svn.reactos.org/svn/reactos?rev=52522&view=rev
Log:
[LDR]
- "Just to be sure" is no reason to overwrite a potential DLL load failure 
status

Modified:
    trunk/reactos/dll/ntdll/ldr/ldrapi.c

Modified: trunk/reactos/dll/ntdll/ldr/ldrapi.c
URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev=...
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Sun Jul  3 20:16:12 
2011
@@ -345,9 +345,6 @@
                          DllName,
                          BaseAddress,
                          TRUE);
-
-    /* Set it to success just to be sure */
-    Status = STATUS_SUCCESS;

/* Restore the old TLD DLL */
     LdrpTopLevelDllBeingLoaded = OldTldDll;