Re: [ros-dev] [ros-diffs] [spetreolle] 50454: [CMAKE] Use cmake subversion capabilities to generate buildno.h and version.h.

[Colin Finck]

spetreolle(a)svn.reactos.org wrote:
>   +       
> subversion_wc_info(${CMAKE_CURRENT_SOURCE_DIR} SVNINFO) 
This will fail when we're not inside a working copy (see 
http://www.vtk.org/Bug/view.php?id=10200), because the macro outputs an 
error in this case.

Please take a look into 
http://svn.reactos.org/svn/project-tools/trunk/rosev_ircsystem/src/CMakeLis…

to see how you can easily reimplement this step properly.

Apart from that, nice to see that we finally get rid of this old stuff! :-)


- Colin

[Amine Khaldi]

> >   +       
> > subversion_wc_info(${CMAKE_CURRENT_SOURCE_DIR} SVNINFO) 
>  This will fail when we're not inside a working copy (see 
>  http://www.vtk.org/Bug/view.php?id=10200), because the macro outputs 
>  an error in this case.  
We call it conditionally based on whether the .svn folder
exists at the 
root of your source tree, indicating a working copy; otherwise we get 
-rUNKNOWN.

Regards,
Amine.