Re: [ros-dev] [ros-diffs] [sginsberg] 41436: - In Win32 DBG is defined to 0 for a non-debug build and to 1 for a debug build. In ReactOS we do this slightly different: DBG is correctly defined to 1 for debug, but not defined at all on non-debug/release build. Because gcc is awesome we can then check for debug compilation with both #ifdef DBG and #if DBG (error free! yay gcc!), and so we have mixed usage all over the tree. - Fix this by defining DBG on non-debug build too and deprecate all usage of #ifdef DB

[Timo Kreuzer]

[e-mail] wrote:
> Author: sginsberg
> Date: Wed Jun 17 16:44:05 2009
> New Revision: 41436
>
> [...] Because gcc is awesome we can then check for debug compilation with both #ifdef DBG and #if DBG (error free! yay gcc!), and so we have mixed usage all over the tree

MSVC behaves exactly the same way ;-P

[KJK::Hyperion]

Timo Kreuzer wrote:
> > [...] Because gcc is awesome we can then check for debug compilation with both #ifdef DBG and #if DBG (error free! yay gcc!), and so we have mixed usage all over the tree
>
> MSVC behaves exactly the same way ;-P

... but warns on -Wall. In gcc, -Wall is useless

[Sarocet]

Timo Kreuzer wrote:
> [e-mail] wrote:
> > Author: sginsberg
> > Date: Wed Jun 17 16:44:05 2009
> > New Revision: 41436
> >
> > [...] Because gcc is awesome we can then check for debug compilation with both #ifdef DBG and #if DBG (error free! yay gcc!), and so we have mixed usage all over the tree
>
> MSVC behaves exactly the same way ;-P

Doesn't the standard specify that a #if against an undefined macro works
as if that macro were 0?