Re: [ros-dev] [ros-diffs] [cmihail] 53537: [shell32.dll] [FORMATTING] - Format the code to a more acceptable level. This is just for my sanity while sifting through it.

[Timo Kreuzer]

Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org:
>   Author: cmihail
>  Date: Sat Sep  3 00:08:11 2011
>  New Revision: 53537
>
>  URL:http://svn.reactos.org/svn/reactos?rev=53537&view=rev
>  Log:
>  [shell32.dll]
>  [FORMATTING]
>  - Format the code to a more acceptable level. This is just for my sanity while sifting
> through it. 
>                 /* skip the remaining spaces */
>  -            while (*cs==0x0009 || *cs==0x0020) {
>  +            while (*cs==0x0009 || *cs==0x0020)
>  +			{
>                    cs++;
>                }
>                if (*cs==0)
>  
Please don't mix tabs and spaces or we'll end up looking like GNU style ;-)
Since the file already uses spaces (as we use almost everywhere), please 
stick to that here.

Regards,
Timo

[Claudiu Mihail]

I know...I commited a reformat last night to remove the tabs. My bad.

Best regards,
Claudiu

On Sat, Sep 3, 2011 at 2:14 PM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote:

>   Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org:
>
> >   Author: cmihail
> >  Date: Sat Sep  3 00:08:11 2011
> >  New Revision: 53537
> >
> >
> > URL:http://svn.reactos.org/**svn/reactos?rev=53537&view=rev<http://s…
> >  Log:
> >  [shell32.dll]
> >  [FORMATTING]
> >  - Format the code to a more acceptable level. This is just for my sanity
> >  while sifting through it.
> >  
>                /* skip the remaining spaces */
> >   -            while (*cs==0x0009 || *cs==0x0020)
> > {
> >  +            while (*cs==0x0009 || *cs==0x0020)
> >  +                       {
> >                   cs++;
> >               }
> >               if (*cs==0)
> >
> >  
>  Please don't mix tabs and spaces or we'll end up looking like GNU style
> ;-)
>  Since the file already uses spaces (as we use almost everywhere), please
>  stick to that here.
>
>  Regards,
>  Timo
>
>
>  ______________________________**_________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>
> http://www.reactos.org/**mailman/listinfo/ros-dev<http://www.reactos.org…
>

[Alex Ionescu]

Also if you're going to un-WINE it, might as well use L' ' and
L'\t'....
instead of hex magix.

Best regards,
Alex Ionescu


On Sat, Sep 3, 2011 at 12:14 PM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote:

>   Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org:
>
>   Author: cmihail
> >   Date: Sat Sep  3 00:08:11 2011
> >  New Revision: 53537
> >
> >
> > URL:http://svn.reactos.org/**svn/reactos?rev=53537&view=rev<http://s…
> >  Log:
> >  [shell32.dll]
> >  [FORMATTING]
> >  - Format the code to a more acceptable level. This is just for my sanity
> >  while sifting through it.
> >  
>                /* skip the remaining spaces */
> >   -            while (*cs==0x0009 || *cs==0x0020)
> > {
> >  +            while (*cs==0x0009 || *cs==0x0020)
> >  +                       {
> >                   cs++;
> >               }
> >               if (*cs==0)
> >
> >  
>  Please don't mix tabs and spaces or we'll end up looking like GNU style
> ;-)
>  Since the file already uses spaces (as we use almost everywhere), please
>  stick to that here.
>
>  Regards,
>  Timo
>
>
>  ______________________________**_________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>
> http://www.reactos.org/**mailman/listinfo/ros-dev<http://www.reactos.org…
>