Re: [ros-diffs] [ion] 16804: - Include ctype.h by default.

[Hartmut Birr]

ion(a)svn.reactos.com wrote:

>  - Include ctype.h by default.
>
> Modified: trunk/reactos/w32api/include/winnt.h
>   
>
>  ------------------------------------------------------------------------
>  *Modified: trunk/reactos/w32api/include/winnt.h*
>
> --- trunk/reactos/w32api/include/winnt.h	2005-07-27 16:34:14 UTC (rev 16803)
> +++ trunk/reactos/w32api/include/winnt.h	2005-07-27 16:55:40 UTC (rev 16804)
> @@ -34,6 +34,7 @@
>
>  extern "C" {
>  #endif
>  
>   
>
> +#include <ctype.h>
>   
>
>  #include <winerror.h>
>  
>  #ifndef RC_INVOKED
>   
>  
Hi,

this changing is wrong (and some other with ctype.h). You can't include
ctype.h from mingw for optimized builds (DBG = 0), because ctype.h from
mingw needs to import msvcrt.dll.

- Hartmut

[Alex Ionescu]

Hartmut Birr wrote:

>  ion(a)svn.reactos.com wrote:
>
>   
>
> >  - Include ctype.h by default.
> >
> > Modified: trunk/reactos/w32api/include/winnt.h
> >  
> >
> > ------------------------------------------------------------------------
> > *Modified: trunk/reactos/w32api/include/winnt.h*
> >
> > --- trunk/reactos/w32api/include/winnt.h	2005-07-27 16:34:14 UTC (rev 16803)
> > +++ trunk/reactos/w32api/include/winnt.h	2005-07-27 16:55:40 UTC (rev 16804)
> > @@ -34,6 +34,7 @@
> >
> > extern "C" {
> > #endif
> >
> >  
> >
> > +#include <ctype.h>
> >  
> >
> > #include <winerror.h>
> >
> > #ifndef RC_INVOKED
> >  
> >
> >     
> >  
> Hi,
>
> this changing is wrong (and some other with ctype.h). You can't include
> ctype.h from mingw for optimized builds (DBG = 0), because ctype.h from
> mingw needs to import msvcrt.dll.
>
> - Hartmut
>   
>  
Hi,

ctype.h is included by default by PSDK, so it's not wrong... I think 
that the appropriate gcc CTYPE macro must be used to disable that 
inclusion in DBG = 0... CTYPE_NO_INLINES or something like that.

Best regards,
Alex Ionescu