Unify system icons into one central folder

[Jared Smudde]

Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the icons in trunk
into a central folder in the media folder. Some icons will need to stay because they might
be application specific. The folder can be called icons and it would be organized
according to
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h…. This way,
we can eliminate duplicate icons thus making trunk slightly smaller. It will also make
changing ReactOS to a different icon theme much easier. This idea was suggested by
gigaherz and I would like to see it done. Thanks!
Jared

[Ged Murphy]

I like the idea in general, but there must be a cleaner and more modular way
of doing it instead of dumping everything in one location.

 

In an area where many devs are pushing to modularize things (think current
win32ss and future minwin), this moves the tree in the opposite direction.
If you were a kernel and win32ss guy, you'd then need to have all the icons
for the whole OS in your WC just to build the area you're interested in.

 

This is a kinda ridiculous analogy, but imagine if you had to checkout KDE
just to build the linux kernel.

 

Ged.

 

From: Ros-dev [mailto:[e-mail]] On Behalf Of Jared Smudde
Sent: 24 July 2015 02:39
To: ros-dev(a)reactos.org
Subject: [ros-dev] Unify system icons into one central folder

 

Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the
icons in trunk into a central folder in the media folder. Some icons will
need to stay because they might be application specific. The folder can be
called icons and it would be organized according to
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.ht
ml. This way, we can eliminate duplicate icons thus making trunk slightly
smaller. It will also make changing ReactOS to a different icon theme much
easier. This idea was suggested by gigaherz and I would like to see it done.
Thanks!

 

Jared

[David Quintana (gigaherz)]

Yes, it is indeed a ridiculous analogy. I believe there are too many
advantages to have a unified place to have most of the common icons
usable by any app that needs them.

Note that my idea was for common icons, thing such the usual "objects"
(document icon, folder icon, the configuration cogs, warning triangle,
...) and "actions" (document-new, search, navigate-back/dorward,
zoom-in/out, ...).

I believe this ADDS to modularization, since it removes duplicate
copies of icons and unifies them in a more manageable way, while most
people who work on code are going to download most of ReactOS AND
RosTests either way, because it's not that useful with just the
kernel. ;P

I do admit that it has one bigger side-effect: if someone wants to
"move out" a single module/app away from the rest of the repository,
they'd have to select the required icons manually, but this does not
happen very often and it shouldn't really be bothering us. If a lot of
people are taking pieces of ReactOS and moving them elsewhere, this is
a sign of bad things.

On 24 July 2015 at 10:18, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote:
>   I like the idea in general, but there must be a
> cleaner and more modular way
>  of doing it instead of dumping everything in one location.
>
>
>
>  In an area where many devs are pushing to modularize things (think current
>  win32ss and future minwin), this moves the tree in the opposite direction.
>  If you were a kernel and win32ss guy, you’d then need to have all the icons
>  for the whole OS in your WC just to build the area you’re interested in.
>
>
>
>  This is a kinda ridiculous analogy, but imagine if you had to checkout KDE
>  just to build the linux kernel.
>
>
>
>  Ged.
>
>
>
>  From: Ros-dev [mailto:[e-mail]] On Behalf Of Jared Smudde
>  Sent: 24 July 2015 02:39
>  To: ros-dev(a)reactos.org
>  Subject: [ros-dev] Unify system icons into one central folder
>
>
>
>  Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the
>  icons in trunk into a central folder in the media folder. Some icons will
>  need to stay because they might be application specific. The folder can be
>  called icons and it would be organized according to
>  http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h….
>  This way, we can eliminate duplicate icons thus making trunk slightly
>  smaller. It will also make changing ReactOS to a different icon theme much
>  easier. This idea was suggested by gigaherz and I would like to see it done.
>  Thanks!
>
>
>
>  Jared
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Jared Smudde]

Why not we leave the kernel and win32ss icons where they are and move the rest. win32ss
has around 7 icons that need to be changed when going to a different icon theme.
That's much better than having to go into each folder to check if there's icons in
there. Of course the bitmaps will have to stay in each folder as most of the apps and dlls
have unique bitmaps to them.
Jared

>   Date: Fri, 24 Jul 2015 16:14:24 +0200
>  From: gigaherz(a)gmail.com
>  To: ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] Unify system icons into one central folder
>  
>  Yes, it is indeed a ridiculous analogy. I believe there are too many
>  advantages to have a unified place to have most of the common icons
>  usable by any app that needs them.
>  
>  Note that my idea was for common icons, thing such the usual "objects"
>  (document icon, folder icon, the configuration cogs, warning triangle,
>  ...) and "actions" (document-new, search, navigate-back/dorward,
>  zoom-in/out, ...).
>  
>  I believe this ADDS to modularization, since it removes duplicate
>  copies of icons and unifies them in a more manageable way, while most
>  people who work on code are going to download most of ReactOS AND
>  RosTests either way, because it's not that useful with just the
>  kernel. ;P
>  
>  I do admit that it has one bigger side-effect: if someone wants to
>  "move out" a single module/app away from the rest of the repository,
>  they'd have to select the required icons manually, but this does not
>  happen very often and it shouldn't really be bothering us. If a lot of
>  people are taking pieces of ReactOS and moving them elsewhere, this is
>  a sign of bad things.
>  
>  On 24 July 2015 at 10:18, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote:
> >   I like the idea in general, but there must be a
> > cleaner and more modular way
> >  of doing it instead of dumping everything in one location.
> >
> >
> >
> >  In an area where many devs are pushing to modularize things (think current
> >  win32ss and future minwin), this moves the tree in the opposite direction.
> >  If you were a kernel and win32ss guy, you’d then need to have all the icons
> >  for the whole OS in your WC just to build the area you’re interested in.
> >
> >
> >
> >  This is a kinda ridiculous analogy, but imagine if you had to checkout KDE
> >  just to build the linux kernel.
> >
> >
> >
> >  Ged.
> >
> >
> >
> >  From: Ros-dev [mailto:[e-mail]] On Behalf Of Jared Smudde
> >  Sent: 24 July 2015 02:39
> >  To: ros-dev(a)reactos.org
> >  Subject: [ros-dev] Unify system icons into one central folder
> >
> >
> >
> >  Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the
> >  icons in trunk into a central folder in the media folder. Some icons will
> >  need to stay because they might be application specific. The folder can be
> >  called icons and it would be organized according to
> >  http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h….
> >  This way, we can eliminate duplicate icons thus making trunk slightly
> >  smaller. It will also make changing ReactOS to a different icon theme much
> >  easier. This idea was suggested by gigaherz and I would like to see it done.
> >  Thanks!
> >
> >
> >
> >  Jared
> >
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Ged Murphy]

I'm not sure it won't create as many problems as it solves. The bulk of the
icons are already grouped in setupapi and shell32, and with the exception of
cpls, the majority of the OS uses these icons. Unless there's a full icon
replacement, it's not particularly hard to maintain the existing stuff as
there's very little to change. 

 

What else do you propose to move? Control panel applet icons? Win32 dll
icons? Application icons? What about other resources such as animations or
sounds?

What's the naming convention going to be? Currently shell32 uses the
resource ids from 2k3 as their names as it makes them easy to compare
directly. 

 

I'm not saying it's a bad idea, I'm just saying that you can't propose
"let's move all the icons to one folder" without providing a plan

Can you or David (or anyone else) come up with a proposal that works?

 

I'm guessing you're thinking something like the following:

 

Root 

                Shell

                                Icons

                                Bitmaps

                                                Toolbars


                                Animations

                Media

                                Sounds

                                Icons

                System

 

Or do you prefer a layout more akin to how Tango does it just purely for
icons:

Root

                Action

                Animation

                Apps

                Devices

                .

 

 

I'm also guessing you'd want all win32 dlls and cpls try to reference icons
from this folder structure. Anything in base\applications should manage its
own resources.

Anything which doesn't fit (what are the guidelines for "doesn't fit")
should be stored local to the project?

 

Ged.

 

 

From: Ros-dev [mailto:[e-mail]] On Behalf Of Jared Smudde
Sent: 24 July 2015 15:22
To: ReactOS Development List <ros-dev(a)reactos.org>
Subject: Re: [ros-dev] Unify system icons into one central folder

 

Why not we leave the kernel and win32ss icons where they are and move the
rest. win32ss has around 7 icons that need to be changed when going to a
different icon theme. That's much better than having to go into each folder
to check if there's icons in there. Of course the bitmaps will have to stay
in each folder as most of the apps and dlls have unique bitmaps to them.

 

Jared

>   Date: Fri, 24 Jul 2015 16:14:24 +0200
>  From:  <mailto:[e-mail]> gigaherz(a)gmail.com
>  To:  <mailto:[e-mail]> ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] Unify system icons into one central folder
>  
>  Yes, it is indeed a ridiculous analogy. I believe there are too many
>  advantages to have a unified place to have most of the common icons
>  usable by any app that needs them.
>  
>  Note that my idea was for common icons, thing such the usual "objects"
>  (document icon, folder icon, the configuration cogs, warning triangle,
>  ...) and "actions" (document-new, search, navigate-back/dorward,
>  zoom-in/out, ...).
>  
>  I believe this ADDS to modularization, since it removes duplicate
>  copies of icons and unifies them in a more manageable way, while most
>  people who work on code are going to download most of ReactOS AND
>  RosTests either way, because it's not that useful with just the
>  kernel. ;P
>  
>  I do admit that it has one bigger side-effect: if someone wants to
>  "move out" a single module/app away from the rest of the repository,
>  they'd have to select the required icons manually, but this does not
>  happen very often and it shouldn't really be bothering us. If a lot of
>  people are taking pieces of ReactOS and moving them elsewhere, this is
>  a sign of bad things.
>  
>  On 24 July 2015 at 10:18, Ged Murphy <
<mailto:[e-mail]> gedmurphy.maillists(a)gmail.com&gt;
wrote:
>   > I like the idea in general, but there must be a
> cleaner and more modular 
way
>   > of doing it instead of dumping everything in one
> location.
>  >
>  >
>  >
>  > In an area where many devs are pushing to modularize things (think 
current
>   > win32ss and future minwin), this moves the tree
> in the opposite 
direction.
>   > If you were a kernel and win32ss guy, you'd
> then need to have all the 
icons
>   > for the whole OS in your WC just to build the
> area you're interested in.
>  >
>  >
>  >
>  > This is a kinda ridiculous analogy, but imagine if you had to checkout 
KDE
>   > just to build the linux kernel.
>  >
>  >
>  >
>  > Ged.
>  >
>  >
>  >
>  > From: Ros-dev [ <mailto:[e-mail]>
mailto:[e-mail]] On Behalf Of Jared Smudde
>   > Sent: 24 July 2015 02:39
>  > To:  <mailto:[e-mail]> ros-dev(a)reactos.org
>  > Subject: [ros-dev] Unify system icons into one central folder
>  >
>  >
>  >
>  > Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of 
the
>   > icons in trunk into a central folder in the media
> folder. Some icons 
will
>   > need to stay because they might be application
> specific. The folder can 
be
>   > called icons and it would be organized according
> to
>  >
<http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h
tml>
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.ht
ml.
>   > This way, we can eliminate duplicate icons thus
> making trunk slightly
>  > smaller. It will also make changing ReactOS to a different icon theme 
much
>   > easier. This idea was suggested by gigaherz and I
> would like to see it 
done.
>   > Thanks!
>  >
>  >
>  >
>  > Jared
>  >
>  >
>  > _______________________________________________
>  > Ros-dev mailing list
>  >  <mailto:[e-mail]> Ros-dev(a)reactos.org
>  >  <http://www.reactos.org/mailman/listinfo/ros-dev>
http://www.reactos.org/mailman/listinfo/ros-dev
>   
>  _______________________________________________
>  Ros-dev mailing list
>   <mailto:[e-mail]> Ros-dev(a)reactos.org
>   <http://www.reactos.org/mailman/listinfo/ros-dev>
http://www.reactos.org/mailman/listinfo/ros-dev

[Jared Smudde]

The naming scheme is going to be how Linux names icons themes. For example, the setupapi
icons would go into a folder called devices and the computer icon name would become
computer just like Linux calls it. The way we are going to use the icons is replace
"res/computer.ico" with "../../../media/icons/devices/computer.ico".
That way we have one computer icon for the source code as sysdm.cpl, device manager
setupapi, etc. all use the same computer icon. Setuapi uses the same icon twice!  We
won't touch the resource IDs at all. This would be a nice way to shrink the source
code size down a bit as we won't have to download the same icon 5 times. The binaries
size would remain the same. Sounds would stay in the media folder and animations would
move into the animations folder. We would move every thing that can move. Most of the
control panel applets use the app icons from the Linux icon them. For example, WINE IE and
inetcpl.cpl, since the icons are the same, it would be copied to /media/icons/applications
as internet-web-browser.ico as the two apps would share that icon. Hope that clears some
stuff up. :)
Jared

From: gedmurphy.maillists(a)gmail.com
To: ros-dev(a)reactos.org
Date: Fri, 24 Jul 2015 16:32:57 +0100
Subject: Re: [ros-dev] Unify system icons into one central folder

I’m not sure it won’t create as many problems as it solves. The bulk of the icons are
already grouped in setupapi and shell32, and with the exception of cpls, the majority of
the OS uses these icons. Unless there’s a full icon replacement, it’s not particularly
hard to maintain the existing stuff as there’s very little to change.  What else do you
propose to move? Control panel applet icons? Win32 dll icons? Application icons? What
about other resources such as animations or sounds?What’s the naming convention going to
be? Currently shell32 uses the resource ids from 2k3 as their names as it makes them easy
to compare directly.  I’m not saying it’s a bad idea, I’m just saying that you can’t
propose “let’s move all the icons to one folder” without providing a planCan you or David
(or anyone else) come up with a proposal that works? I’m guessing you’re thinking
something like the following: Root                 Shell                               
Icons                                Bitmaps                                              
 Toolbars                                                               Animations        
       Media                                Sounds                                Icons   
            System Or do you prefer a layout more akin to how Tango does it just purely
for icons:Root                Action                Animation                Apps         
      Devices                …  I’m also guessing you’d want all win32 dlls and cpls try
to reference icons from this folder structure. Anything in base\applications should manage
its own resources.Anything which doesn’t fit (what are the guidelines for “doesn’t fit”)
should be stored local to the project? Ged.  From: Ros-dev
[mailto:[e-mail]] On Behalf Of Jared Smudde
Sent: 24 July 2015 15:22
To: ReactOS Development List <ros-dev(a)reactos.org>
Subject: Re: [ros-dev] Unify system icons into one central folder Why not we leave the
kernel and win32ss icons where they are and move the rest. win32ss has around 7 icons that
need to be changed when going to a different icon theme. That's much better than
having to go into each folder to check if there's icons in there. Of course the
bitmaps will have to stay in each folder as most of the apps and dlls have unique bitmaps
to them. Jared> Date: Fri, 24 Jul 2015 16:14:24 +0200
>   From: gigaherz(a)gmail.com
>  To: ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] Unify system icons into one central folder
>  
>  Yes, it is indeed a ridiculous analogy. I believe there are too many
>  advantages to have a unified place to have most of the common icons
>  usable by any app that needs them.
>  
>  Note that my idea was for common icons, thing such the usual "objects"
>  (document icon, folder icon, the configuration cogs, warning triangle,
>  ...) and "actions" (document-new, search, navigate-back/dorward,
>  zoom-in/out, ...).
>  
>  I believe this ADDS to modularization, since it removes duplicate
>  copies of icons and unifies them in a more manageable way, while most
>  people who work on code are going to download most of ReactOS AND
>  RosTests either way, because it's not that useful with just the
>  kernel. ;P
>  
>  I do admit that it has one bigger side-effect: if someone wants to
>  "move out" a single module/app away from the rest of the repository,
>  they'd have to select the required icons manually, but this does not
>  happen very often and it shouldn't really be bothering us. If a lot of
>  people are taking pieces of ReactOS and moving them elsewhere, this is
>  a sign of bad things.
>  
>  On 24 July 2015 at 10:18, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote:
> >   I like the idea in general, but there must be a
> > cleaner and more modular way
> >  of doing it instead of dumping everything in one location.
> >
> >
> >
> >  In an area where many devs are pushing to modularize things (think current
> >  win32ss and future minwin), this moves the tree in the opposite direction.
> >  If you were a kernel and win32ss guy, you’d then need to have all the icons
> >  for the whole OS in your WC just to build the area you’re interested in.
> >
> >
> >
> >  This is a kinda ridiculous analogy, but imagine if you had to checkout KDE
> >  just to build the linux kernel.
> >
> >
> >
> >  Ged.
> >
> >
> >
> >  From: Ros-dev [mailto:[e-mail]] On Behalf Of Jared Smudde
> >  Sent: 24 July 2015 02:39
> >  To: ros-dev(a)reactos.org
> >  Subject: [ros-dev] Unify system icons into one central folder
> >
> >
> >
> >  Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the
> >  icons in trunk into a central folder in the media folder. Some icons will
> >  need to stay because they might be application specific. The folder can be
> >  called icons and it would be organized according to
> >  http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h….
> >  This way, we can eliminate duplicate icons thus making trunk slightly
> >  smaller. It will also make changing ReactOS to a different icon theme much
> >  easier. This idea was suggested by gigaherz and I would like to see it done.
> >  Thanks!
> >
> >
> >
> >  Jared
> >
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev