Re: [ros-dev] [ros-diffs] [fireball] 24848: i386BootDrive and i386BootPartition are ULONGs, and before saving a byte value they must be zeroed. Thanks to Magnus for identifying the problem.

[Alex Ionescu]

fireball(a)svn.reactos.org wrote:
>   Author: fireball
>  Date: Mon Nov 27 00:46:45 2006
>  New Revision: 24848
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=24848&view=rev
>  Log:
>  i386BootDrive and i386BootPartition are ULONGs, and before saving a byte value they must
> be zeroed. 
Ever heard of movzx?


-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[Brian Palmer]

Um, these values are initialized to zero at link time. So this is just
wasted code...

-Brian

-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Alex Ionescu
Sent: Sunday, November 26, 2006 5:16 PM
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [fireball] 24848: i386BootDrive and
i386BootPartition are ULONGs, and before saving a byte value they must be
zeroed. Thanks to Magnus for identifying the problem.

fireball(a)svn.reactos.org wrote:
>   Author: fireball
>  Date: Mon Nov 27 00:46:45 2006
>  New Revision: 24848
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=24848&view=rev
>  Log:
>  i386BootDrive and i386BootPartition are ULONGs, and before saving a byte 
value they
must be zeroed.

Ever heard of movzx?


-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev