Re: [ros-diffs] [sedwards] 15091: remove trailing whitespace at end of lines

[Alex Ionescu]

sedwards(a)svn.reactos.com wrote:

>  remove trailing whitespace at end of lines
>
>  *[truncated at 1000 lines; 37354 more skipped]* 
Steven,

This patch is unacceptably large, and your commit message is way too 
short to explain all the changes. Please revert the patch immediately 
and work on a branch, submitting small patches at a time so that other 
developers can review them. Also, formatting patches are prohibited, so 
I don't think your patches can be accepted at all, even if in a branch.

Best regards,
Alex Ionescu

<If anyone did not notice the sarcasm, please shoot yourselves. Great 
work Steven; I hoped you used an automated tool!>

[Hartmut Birr]

Alex Ionescu wrote:

>   sedwards(a)svn.reactos.com wrote:
>
> >   remove trailing whitespace at end of lines
> >
> >  *[truncated at 1000 lines; 37354 more skipped]* 
>
>  Steven,
>
>  This patch is unacceptably large, and your commit message is way too
>  short to explain all the changes. Please revert the patch immediately
>  and work on a branch, submitting small patches at a time so that other
>  developers can review them. Also, formatting patches are prohibited,
>  so I don't think your patches can be accepted at all, even if in a
>  branch.
>  
Bla, bla, bla.
If a developer says 'I've only removed spaces', I trust him. No, I
doesn't trust him. I checkout his changes and the source before. I
compare the sources. After this I apologise silent, because I was
mistrustful. Steven has done, what he says.

- Hartmut

[Thomas Weidenmueller]

Hartmut Birr wrote:
>   Bla, bla, bla.
>  If a developer says 'I've only removed spaces', I trust him. No, I
>  doesn't trust him. I checkout his changes and the source before. I
>  compare the sources. After this I apologise silent, because I was
>  mistrustful. Steven has done, what he says. 
haha lol

Thomas

[Alex Ionescu]

Hartmut Birr wrote:

>    
>
> Bla, bla, bla.
> If a developer says 'I've only removed spaces', I trust him. No, I
> doesn't trust him. I checkout his changes and the source before. I
> compare the sources. After this I apologise silent, because I was
> mistrustful. Steven has done, what he says.
>
> - Hartmut
>
>   
>  
LOL =)

The joke is on you, Hartmut!

Best regards,
Alex Ionescu

[Hartmut Birr]

Alex Ionescu wrote:

>   sedwards(a)svn.reactos.com wrote:
>
> >   remove trailing whitespace at end of lines
> >
> >  *[truncated at 1000 lines; 37354 more skipped]* 
>
>  Steven,
>
>  This patch is unacceptably large, and your commit message is way too
>  short to explain all the changes. Please revert the patch immediately
>  and work on a branch, submitting small patches at a time so that other
>  developers can review them. Also, formatting patches are prohibited,
>  so I don't think your patches can be accepted at all, even if in a
>  branch.
>
>  Best regards,
>  Alex Ionescu
>
>  <If anyone did not notice the sarcasm, please shoot yourselves. Great
>  work Steven; I hoped you used an automated tool!> 
Oops, I've read the last line to late.

- Hartmut