Re: [ros-dev] [ros-diffs] [spetreolle] 71201: [CDMAKE] Don't check for extension length on Joliet images. Encountered with AHK binaries. ONLINE-567

[Pierre Schweitzer]

Given there seems to be no place where s is checked for length, it would
be more appropriated to perform such as check:

if ((!joliet && strlen(s) > MAX_EXTENSION_LENGTH) || strlen(s) >
MAX_NAME_LENGTH)

Le 24/04/2016 20:59, spetreolle(a)svn.reactos.org a écrit :
>   Author: spetreolle
>  Date: Sun Apr 24 18:59:33 2016
>  New Revision: 71201
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=71201&view=rev
>  Log:
>  [CDMAKE]
>  Don't check for extension length on Joliet images.
>  Encountered with AHK binaries.
>  
>  ONLINE-567
>  
>  Modified:
>      trunk/reactos/sdk/tools/cdmake/cdmake.c
>  
>  Modified: trunk/reactos/sdk/tools/cdmake/cdmake.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/tools/cdmake/cdmake.c?…
>  ==============================================================================
>  --- trunk/reactos/sdk/tools/cdmake/cdmake.c	[iso-8859-1] (original)
>  +++ trunk/reactos/sdk/tools/cdmake/cdmake.c	[iso-8859-1] Sun Apr 24 18:59:33 2016
>  @@ -692,7 +692,8 @@
>               error_exit("'%s' is not ISO-9660, aborting...",
> filename);
>           s++;
>       }
>  -    if (strlen(s) > MAX_EXTENSION_LENGTH)
>  +    // Check for extension length
>  +    if (!joliet && strlen(s) > MAX_EXTENSION_LENGTH)
>       {
>           error_exit("'%s' has too long extension, aborting...",
> filename);
>       }
>  
>   

-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.