Fedora 13 Build Error

[James Tabor]

I ran into this on Fedora 13,
[HOST-CC]  tools/cabman/cabinet.cxx
tools/cabman/cabinet.cxx: In member function ‘bool
CCabinet::CreateSimpleCabinet()’:
tools/cabman/cabinet.cxx:2177: error: no matching function for call to
‘stat::stat(char [260], stat*)’
/usr/include/bits/stat.h:40: note: candidates are: stat::stat()
/usr/include/bits/stat.h:40: note:                 stat::stat(const stat&)
from http://code.google.com/p/libproxy/issues/detail?id=122 the patch
is based on this;
http://code.google.com/p/libproxy/issues/attachmentText?id=122&aid=2002…
Index: tools/cabman/cabinet.cxx
===================================================================
--- tools/cabman/cabinet.cxx    (revision 48297)
+++ tools/cabman/cabinet.cxx    (working copy)
@@ -21,7 +21,8 @@
 #if !defined(WIN32)
 # include <dirent.h>
 #endif
-#if defined(__FreeBSD__) || defined(__APPLE__)
+#if !defined(WIN32) || defined(__FreeBSD__) || defined(__APPLE__)
+# include <sys/types.h>
 # include <sys/stat.h>
 #endif // __FreeBSD__
 #include "cabinet.h"
Not sure this is right, so~ posted here for fast review and fix,
James

[Sylvain Petreolle]

Hi James,
reactos has now officially 2 fedora 13 users ;)
Since noone notified until today, not even the unix buildbot,
Im building reactos using the same kind of fix since months.
Feel free to commit.
Kind regards,
Sylvain Petreolle
----- Message d'origine ----
>   De : James Tabor <jimtabor.rosdev(a)gmail.com>
>  À : ReactOS Development List <ros-dev(a)reactos.org>
>  Envoyé le : Mar 27 juillet 2010, 5h 48min 54s
>  Objet : [ros-dev] Fedora 13 Build Error
>  I ran into this on Fedora 13,
>  [HOST-CC]   tools/cabman/cabinet.cxx
>  tools/cabman/cabinet.cxx: In member function  ‘bool
>  CCabinet::CreateSimpleCabinet()’:
>  tools/cabman/cabinet.cxx:2177:  error: no matching function for call to
>  ‘stat::stat(char [260],  stat*)’
>  /usr/include/bits/stat.h:40: note: candidates are:  stat::stat()
>  /usr/include/bits/stat.h:40: note:                  stat::stat(const stat&)
>  from http://code.google.com/p/libproxy/issues/detail?id=122 the patch
>  is  based on this;
> http://code.google.com/p/libproxy/issues/attachmentText?id=122&aid=2002…
>  Index: tools/cabman/cabinet.cxx
>  ===================================================================
>  --- - tools/cabman/cabinet.cxx    (revision 48297)
>  +++  tools/cabman/cabinet.cxx    (working copy)
>  @@ -21,7 +21,8  @@
>   #if !defined(WIN32)
>   # include <dirent.h>
>   #endif
>  -#if  defined(__FreeBSD__) || defined(__APPLE__)
>  +#if !defined(WIN32) ||  defined(__FreeBSD__) || defined(__APPLE__)
>  +# include <sys/types.h>
>    # include <sys/stat.h>
>   #endif // __FreeBSD__
>   #include  "cabinet.h"
>  Not sure this is right, so~ posted here for fast review and  fix,
>  James
>  _______________________________________________
>  Ros-dev  mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[James Tabor]

Hi!
On Wed, Jul 28, 2010 at 5:27 PM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote:
>   Hi James,
>  reactos has now officially 2 fedora 13 users ;)
>  Since noone notified until today, not even the unix buildbot,
>  Im building reactos using the same kind of fix since months.
>  Feel free to commit.
>  Kind regards,
>  Sylvain Petreolle
>  
Nice! I will get to test slackware 13.x and the other fedora distros
soon before doing the commit.
Thanks,
James

[Colin Finck]

James Tabor <jimtabor.rosdev(a)gmail.com> wrote:
>   Nice! I will get to test slackware 13.x and the other
> fedora distros
>  soon before doing the commit. 
You should be able to simplify your patch to:
Index: tools/cabman/cabinet.cxx
===================================================================
--- tools/cabman/cabinet.cxx    (revision 48297)
+++ tools/cabman/cabinet.cxx    (working copy)
@@ -21,7 +21,8 @@
  #if !defined(WIN32)
  # include <dirent.h>
+# include <sys/stat.h>
+# include <sys/types.h>
  #endif
-#if defined(__FreeBSD__) || defined(__APPLE__)
-# include <sys/stat.h>
-#endif // __FreeBSD__
Untested and mocked up, but you should get the idea :-)
Both added includes are part of the Open Group Base Specifications, so
there should be no harm in including them on all modern Unix systems.
Cheers,
Colin

[James Tabor]

Hi!
I attempted to commit this, but~
I've tested Fedora 6, 8, 10 - 12 and Slackware 12.x and 13.x without
issues. Someone with Apple and FreeBSD build systems need to test
this.
Thanks for helping,
James
On Sat, Jul 31, 2010 at 6:39 AM, Colin Finck <mail(a)colinfinck.de> wrote:
>   James Tabor <jimtabor.rosdev(a)gmail.com> wrote:
> >  Nice! I will get to test slackware 13.x and the other fedora distros
> >  soon before doing the commit. 
>  You should be able to simplify your patch to:
>  Index: tools/cabman/cabinet.cxx
>  ===================================================================
>  --- tools/cabman/cabinet.cxx    (revision 48297)
>  +++ tools/cabman/cabinet.cxx    (working copy)
>  @@ -21,7 +21,8 @@
>   #if !defined(WIN32)
>   # include <dirent.h>
>  +# include <sys/stat.h>
>  +# include <sys/types.h>
>   #endif
>  -#if defined(__FreeBSD__) || defined(__APPLE__)
>  -# include <sys/stat.h>
>  -#endif // __FreeBSD__
>  Untested and mocked up, but you should get the idea :-)
>  Both added includes are part of the Open Group Base Specifications, so there
>  should be no harm in including them on all modern Unix systems.
>  Cheers,
>  Colin