shell32 vs. shell32_new

[Gregor Schneider]

Hi ros-dev,

I've seen shell32_new being added into trunk by r51768, but haven't heard of
anything else about it. From what I can see it changes shell32 from C to
C++, which looks like a good move.

Problematic seems to me that it is completely out of sync with trunk's
shell32 (judging from the translations alone).
It might also be annoying for merging future patches, since the C to C++
move changes the code substantially.

So are there any plans concering shell32_new? Do I have to merge all code
changes in C and C++ or is shell32(_old) going to be dumped anytime soon?

Best regards,
Gregor

[Ged Murphy]

Yes, it's a partial change from C to C++. There should be no
functional change from the existing code.

The idea is to merge all the recent changes from shell32 into
shell32_new and then dump the existing C code.
I'm just too busy with work to do it at the moment. If someone could
do it, then I'd be grateful.
Otherwise we either have to keep both dlls in sync from now on, or
forget the new code for now until someone has the time to fully sync.

Future syncs shouldn't be too much of a problem, most of the code we
take from Wine should easily drop into the new C++ code.
We're partially forked anyway, and if we intend on improving our own
shell support (which is what the big push is at the moment), then
we're going to have to totally fork from Wine as they don't need the
same level of support that we need.

Ged.



On 19 May 2011 19:37, Gregor Schneider <grschneider(a)gmail.com> wrote:
>   Hi ros-dev,
>
>  I've seen shell32_new being added into trunk by r51768, but haven't heard of
>  anything else about it. From what I can see it changes shell32 from C to
>  C++, which looks like a good move.
>
>  Problematic seems to me that it is completely out of sync with trunk's
>  shell32 (judging from the translations alone).
>  It might also be annoying for merging future patches, since the C to C++
>  move changes the code substantially.
>
>  So are there any plans concering shell32_new? Do I have to merge all code
>  changes in C and C++ or is shell32(_old) going to be dumped anytime soon?
>
>  Best regards,
>  Gregor
>
>
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>