Re: [ros-svn] [turner] 20194: set default res to 800x600x16

[David Hinz]

Could you do this for trunk too?
It is very annoying, if you can't see the buttons of the locale dialog, 
plus it looks very unprofessional...

Maybe at least 800x600x8.

Greets,

David Hinz

[e-mail] schrieb:
> set default res to 800x600x16
>
> Updated files:
> branches/ros-branch-0_2_9/reactos/bootdata/hivesys.inf
>
> Ros-svn mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-svn

[Brandon Turner]

It looks like people in IRC want me to revert it in the branch already.  
;)  So I really doubt it will make it to trunk.

Brandon

David Hinz wrote:
> Could you do this for trunk too?
> It is very annoying, if you can't see the buttons of the locale 
> dialog, plus it looks very unprofessional...
>
> Maybe at least 800x600x8.
>
> Greets,
>
> David Hinz
>
> [e-mail] schrieb:
> > set default res to 800x600x16
> >
> > Updated files:
> > branches/ros-branch-0_2_9/reactos/bootdata/hivesys.inf
> >
> > Ros-svn mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-svn
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Maarten Bosma]

It has been reverted because it would make reactos unusable with old 
monitors, but Magnus Olsen suggested to make it a option at the installer.

David Hinz wrote:
> Could you do this for trunk too?
> It is very annoying, if you can't see the buttons of the locale 
> dialog, plus it looks very unprofessional...
>
> Maybe at least 800x600x8.
>
> Greets,
>
> David Hinz
>
> [e-mail] schrieb:
> > set default res to 800x600x16
> >
> > Updated files:
> > branches/ros-branch-0_2_9/reactos/bootdata/hivesys.inf
> >
> > Ros-svn mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-svn
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[David Hinz]

Well maybe, then we should change the affected dialogs, as this can't be 
this way forever, there has to be a final solution, so that users are 
able to see the whole dialog.
I don't mind the resolution to stay 640x480, the problem is just not all 
dialogs are completely visible.

Greets,

David Hinz

Maarten Bosma schrieb:
> It has been reverted because it would make reactos unusable with old 
> monitors, but Magnus Olsen suggested to make it a option at the installer.

[Ge van Geldorp]

> From: David Hinz
>
> Well maybe, then we should change the affected dialogs, as 
> this can't be this way forever, there has to be a final 
> solution, so that users are able to see the whole dialog.

Way ahead of you :-) Already done in r20176

GvG

[David Hinz]

Sorry, didn't see this one, I will check it right now.

Greets,

David Hinz

Ge van Geldorp schrieb:
> > From: David Hinz
> >
> > Well maybe, then we should change the affected dialogs, as 
> > this can't be this way forever, there has to be a final 
> > solution, so that users are able to see the whole dialog.
>
> Way ahead of you :-) Already done in r20176
>
> GvG
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Maarten Bosma]

In revision 20194 Brandon Turner changed to default resolution to 
800x600x16. Many people were not happy with it, especially GreateLord 
how has got a monitor that is capable of that resolution. On the other 
hand ReactOS looks way better in 800x600x16. Especially if we want to 
include photo wallpapers, it is a bad idea imo if the they won't work 
with the standard resolution.

It was GreatLord's idea to make it a option at 1st stage installer, that 
way the default can stay 800x600 but people with old monitors got a 
chance to choose 640x680. So here is the patch.

Maarten Bosma

Index: subsys/system/usetup/settings.c
===================================================================
--- subsys/system/usetup/settings.c	(revision 20296)
+++ subsys/system/usetup/settings.c	(working copy)
@@ -521,6 +521,66 @@
       return FALSE;
     }

+  /* Set the resolution */
+  // ToDo:
+  //  * get Driver Name into Path
+  PWCHAR Buffer;
+  if (!InfGetDataField(Context, 4, &Buffer))
+    {
+      DPRINT("InfGetDataField() failed\n");
+      return FALSE;
+    }
+  ULONG Width = wcstoul(Buffer, NULL, 0);
+  Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
+				 L"\Registry\Machine\System\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", // FIXME: Do not hardcode driver name
+				 L"DefaultSettings.XResolution",
+				 REG_DWORD,
+				 &Width,
+				 sizeof(ULONG));
+  if (!NT_SUCCESS(Status))
+    {
+      DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
+      return FALSE;
+    }
+
+  
+  if (!InfGetDataField(Context, 5, &Buffer))
+    {
+      DPRINT("InfGetDataField() failed\n");
+      return FALSE;
+    }
+  ULONG Hight = wcstoul(Buffer, NULL, 0);
+  Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
+				 L"\Registry\Machine\System\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", // FIXME: Do not hardcode driver name
+				 L"DefaultSettings.YResolution",
+				 REG_DWORD,
+				 &Hight,
+				 sizeof(ULONG));
+  if (!NT_SUCCESS(Status))
+    {
+      DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
+      return FALSE;
+    }
+
+  if (!InfGetDataField(Context, 6, &Buffer))
+    {
+      DPRINT("InfGetDataField() failed\n");
+      return FALSE;
+    }
+  ULONG Bpp = wcstoul(Buffer, NULL, 0);
+  Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
+				 L"\Registry\Machine\System\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", // FIXME: Do not hardcode driver name
+				 L"DefaultSettings.BitsPerPel",
+				 REG_DWORD,
+				 &Bpp,
+				 sizeof(ULONG));
+  if (!NT_SUCCESS(Status))
+    {
+      DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
+      return FALSE;
+    }
+
+  /* Enable the right driver */
   if (!InfGetDataField(Context, 3, &ServiceName))
     {
       DPRINT("InfGetDataField() failed\n");
Index: bootdata/txtsetup.sif
===================================================================
--- bootdata/txtsetup.sif	(revision 20296)
+++ bootdata/txtsetup.sif	(working copy)
@@ -66,9 +66,10 @@
 halmp.dll    = 2,hal.dll

[Display]
-;<id> = <user friendly name>,<spare>,<service key name>
-vga = "VGA Display",,Vga
-vbe = "VESA Display",,VBE
+;<id> = <user friendly name>,<spare>,<service key name>,<hight>,<width>,<bpp>
+vga = "VGA Display (640x680x8)",,Vga,640,480,8
+vbe_lowres = "VESA Display (640x680x8)",,VBE,640,480,8
+vbe = "VESA Display (800x600x16)",,VBE,800,600,16

[Map.Display]
 ;<id> = <pnp id string>

[Magnus Olsen]

Do not hard the drv. that is bad with u patch
But we are using the vbe as defualt drv.
in second boot. and there it change the drv by the pnp if it found another
one.
I can liv with that small problem. rember vga drv can only work with
640x480x 8bits (640x480 with 256 color) .

----- Original Message ----- 
From: "Maarten Bosma" [e-mail]
To: "ReactOS Development List" [e-mail]
Sent: den 23 December 2005 12:29
Subject: [ros-dev] Change resolution in 1st stage installer (Patch to
review)
> In revision 20194 Brandon Turner changed to default resolution to
> 800x600x16. Many people were not happy with it, especially GreateLord
> how has got a monitor that is capable of that resolution. On the other
> hand ReactOS looks way better in 800x600x16. Especially if we want to
> include photo wallpapers, it is a bad idea imo if the they won't work
> with the standard resolution.
>
> It was GreatLord's idea to make it a option at 1st stage installer, that
> way the default can stay 800x600 but people with old monitors got a
> chance to choose 640x680. So here is the patch.
>
> Maarten Bosma

----------------------------------------------------------------------------
----
> Index: subsys/system/usetup/settings.c
>
> --- subsys/system/usetup/settings.c (revision 20296)
> +++ subsys/system/usetup/settings.c (working copy)
> @@ -521,6 +521,66 @@
>        return FALSE;
>      }
> /* Set the resolution */
> // ToDo:
> //  * get Driver Name into Path
> PWCHAR Buffer;
> if (!InfGetDataField(Context, 4, &Buffer))
> {
>  DPRINT("InfGetDataField() failed\n");
>  return FALSE;
> }
> ULONG Width = wcstoul(Buffer, NULL, 0);
> Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
> L"\Registry\Machine\System\CurrentControlSet\Hardware

Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", //
FIXME: Do not hardcode driver name
> L"DefaultSettings.XResolution",
> REG_DWORD,
> &Width,
> sizeof(ULONG));
> if (!NT_SUCCESS(Status))
> {
>  DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
>  return FALSE;
> }
> if (!InfGetDataField(Context, 5, &Buffer))
> {
>  DPRINT("InfGetDataField() failed\n");
>  return FALSE;
> }
> ULONG Hight = wcstoul(Buffer, NULL, 0);
> Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
> L"\Registry\Machine\System\CurrentControlSet\Hardware

Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", //
FIXME: Do not hardcode driver name
> L"DefaultSettings.YResolution",
> REG_DWORD,
> &Hight,
> sizeof(ULONG));
> if (!NT_SUCCESS(Status))
> {
>  DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
>  return FALSE;
> }
> if (!InfGetDataField(Context, 6, &Buffer))
> {
>  DPRINT("InfGetDataField() failed\n");
>  return FALSE;
> }
> ULONG Bpp = wcstoul(Buffer, NULL, 0);
> Status = RtlWriteRegistryValue(RTL_REGISTRY_ABSOLUTE,
> L"\Registry\Machine\System\CurrentControlSet\Hardware

Profiles\Current\System\CurrentControlSet\Services\VBE\Device0", //
FIXME: Do not hardcode driver name
> L"DefaultSettings.BitsPerPel",
> REG_DWORD,
> &Bpp,
> sizeof(ULONG));
> if (!NT_SUCCESS(Status))
> {
>  DPRINT("RtlWriteRegistryValue() failed (Status %lx)\n", Status);
>  return FALSE;
> }
> /* Enable the right driver */
> if (!InfGetDataField(Context, 3, &ServiceName))
>   {
>     DPRINT("InfGetDataField() failed\n");
> Index: bootdata/txtsetup.sif
>
> --- bootdata/txtsetup.sif (revision 20296)
> +++ bootdata/txtsetup.sif (working copy)
> @@ -66,9 +66,10 @@
>  halmp.dll    = 2,hal.dll
>
> [Display]
> -;<id> = <user friendly name>,<spare>,<service key name>
> -vga = "VGA Display",,Vga
> -vbe = "VESA Display",,VBE
> +;<id> = <user friendly name>,<spare>,<service key

name>,<hight>,<width>,<bpp>
> +vga = "VGA Display (640x680x8)",,Vga,640,480,8
> +vbe_lowres = "VESA Display (640x680x8)",,VBE,640,480,8
> +vbe = "VESA Display (800x600x16)",,VBE,800,600,16
>
> [Map.Display]
>  ;<id> = <pnp id string>

----------------------------------------------------------------------------
----
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Maarten Bosma]

Magnus Olsen wrote:
> Do not hard the drv. that is bad with u patch
> But we are using the vbe as defualt drv.
> in second boot. and there it change the drv by the pnp if it found another
> one.
> I can liv with that small problem. rember vga drv can only work with
> 640x480x 8bits (640x480 with 256 color) .

I fixed that and commited it in r20313.

Maarten Bosma

[Reuben Perelman]

Maarten Bosma wrote:
> It has been reverted because it would make reactos unusable with old 
> monitors, but Magnus Olsen suggested to make it a option at the 
> installer.

I don't think I've ever seen a monitor not capable of 800x600. And I've 
only seen one monitor only capable of 800x600. Most of the monitors I've 
seen are a capable of at least 1280x1024.

Maybe the solution for reactos is to make the dialogs smaller so they're 
usable at 640x480.
> David Hinz wrote:
> > Could you do this for trunk too?
> > It is very annoying, if you can't see the buttons of the locale 
> > dialog, plus it looks very unprofessional...
> >
> > Maybe at least 800x600x8.
> >
> > Greets,
> >
> > David Hinz
> >
> > [e-mail] schrieb:
> > > set default res to 800x600x16
> > >
> > > Updated files:
> > > branches/ros-branch-0_2_9/reactos/bootdata/hivesys.inf
> > >
> > > Ros-svn mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-svn
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Steven Edwards]

Hi,

On 12/15/05, Reuben Perelman [e-mail] wrote:
> Maybe the solution for reactos is to make the dialogs smaller so they're
> usable at 640x480.

Yes this would really be the best from my point of view. A good number
of the dialogs in Windows are still rather stupidly hardcoded for a
size that does not work at lower resolutions. IMHO this is one area we
could differ and be better without breaking compatibility.

--
Steven Edwards - ReactOS and Wine developer

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[David Hinz]

Maybe we could rework the complete setup (not just the first part) and 
create a fullscreen installer.
I don't know, how difficult this is, but I think it would be a good 
idea, as it even looks better than our current win2k style setup and 
gives the user the impression, he is currently installing ReactOS and 
not just changing some preferences. I just doesn't look like the 
control-apps.

Greets,

David Hinz

Steven Edwards schrieb:
> Hi,
>
> On 12/15/05, Reuben Perelman [e-mail] wrote:
> > Maybe the solution for reactos is to make the dialogs smaller so they're
> > usable at 640x480.
>
> Yes this would really be the best from my point of view. A good number
> of the dialogs in Windows are still rather stupidly hardcoded for a
> size that does not work at lower resolutions. IMHO this is one area we
> could differ and be better without breaking compatibility.
>
> --
> Steven Edwards - ReactOS and Wine developer
>
> "There is one thing stronger than all the armies in the world, and
> that is an idea whose time has come." - Victor Hugo
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev