Re: [ros-diffs] [ea] 18230: More fixes to compile.

[Alex Ionescu]

[e-mail] wrote:
> More fixes to compile.
>
> Modified: trunk/reactos/subsys/csr/csrsrv/api.c
> Modified: trunk/reactos/subsys/csr/csrsrv/process.c
>
> *Mo*

What compiler are you using? My gcc 3.4.4 compiled the files perfectly, 
so did msvc 2k5 with maximum prefast warnings on. Initializing all those 
variables to NULL seems an awful waste to me..

Best regards,
Alex Ionescu

[Emanuele Aliberti]

Alex Ionescu wrote:
> [e-mail] wrote:
> > More fixes to compile.
> >
> > Modified: trunk/reactos/subsys/csr/csrsrv/api.c
> > Modified: trunk/reactos/subsys/csr/csrsrv/process.c
> >
> > *Mo*
>
> What compiler are you using? My gcc 3.4.4 compiled the files 
> perfectly, so did msvc 2k5 with maximum prefast warnings on. 
> Initializing all those variables to NULL seems an awful waste to me..

d:\src\ros\trunk>gcc --version
gcc (GCC) 3.4.2 (mingw-special)
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Is it obsolete? It stopped compiling because it found possibly 
uninitialized variables. IMHO inizializing variables is good practice in 
safe programming.
-- 
:Emanuele Aliberti

[Alex Ionescu]

Emanuele Aliberti wrote:
> >
>
> d:\src\ros\trunk>gcc --version
> gcc (GCC) 3.4.2 (mingw-special)
> Copyright (C) 2004 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There 
> is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR 
> PURPOSE.
>
> Is it obsolete? It stopped compiling because it found possibly 
> uninitialized variables. IMHO inizializing variables is good practice 
> in safe programming.

Hi,

Hmm, you're right, I build with DBG = 1 so I didn't see those errors, my 
bad.

Best regards,
Alex Ionescu