New subject: [ros-diffs] [ion] 19666: - Add DDK alignment macros and move/rename the ones in the NDK for user-mode only (since kernel-mode should use the DDK ones).

27 Nov 2005

ion@svn.reactos.com wrote:
...

Add DDK alignment macros and move/rename the ones in the NDK for user-mode only (since kernel-mode should use the DDK ones).
Fix helper.h's alignment macros to protect properly and also use a faster implementation.
Update NDK readme.

Modified: trunk/reactos/include/ndk/lpctypes.h

*Modified: trunk/reactos/include/ndk/lpctypes.h*

--- trunk/reactos/include/ndk/lpctypes.h	2005-11-26 23:26:04 UTC (rev 19665)
+++ trunk/reactos/include/ndk/lpctypes.h	2005-11-27 02:55:13 UTC (rev 19666)
@@ -234,9 +234,9 @@
 // Maximum total Kernel-Mode LPC Message Structure Size
 //
 #define LPCP_MAX_MESSAGE_SIZE \

ROUND_UP(PORT_MAXIMUM_MESSAGE_LENGTH + \


ALIGN_UP(PORT_MAXIMUM_MESSAGE_LENGTH + \
sizeof(LPCP_MESSAGE) + \



sizeof(LPCP_CONNECTION_MESSAGE), 16)


sizeof(LPCP_CONNECTION_MESSAGE), sizeof(ULONGLONG) * 2)

//
 // Maximum actual LPC Message Length

This or the definition of ALIGN_UP is wrong. ALIGN_UP needs a type as
second parameter. Now the value of LPCP_MAX_MESSAGE_SIZE,
LPC_MAX_MESSAGE_LENGTH and LPC_MAX_DATA_LENGTH are changed. ReactOS
won't boot because csrss uses hard coded values in CsrpCreateListenPort.
- Hartmut

    

Re: [ros-diffs] [ion] 19666: - Add DDK alignment macros and move/rename the ones in the NDK for user-mode only (since kernel-mode should use the DDK ones).