Re: [ros-dev] [ros-diffs] [tkreuzer] 42596: Implement EngFileIoControl and EngFileWrite

[Hervé Poussineau]

tkreuzer(a)svn.reactos.org a écrit :
>   Author: tkreuzer
>  Date: Mon Aug 10 17:09:14 2009
>  New Revision: 42596
>
>  +static
>  +DWORD
>  +EngpFileIoRequest(
>  +    PFILE_OBJECT pFileObject,
>  +    ULONG   ulMajorFunction,
>  +    LPVOID  lpBuffer,
>  +    DWORD   nBufferSize,
>  +    ULONGLONG  ullStartOffset,
>  +    OUT LPDWORD lpInformation)
>  +{ 
[...]

>   +        return STATUS_INVALID_PARAMETER; 
[...]

>   +        return FALSE; 
[...]

>   +    return NT_SUCCESS(Status);
>  +} 
I don't really understand what is supposed to return EngpFileIoRequest? 
A DWORD, a BOOLEAN, or a NTSTATUS?


Hervé

[Alex Ionescu]

And since when is static used in ReactOS kernel code?

Best regards,
Alex Ionescu



On Mon, Aug 10, 2009 at 10:51 AM, Hervé Poussineau<hpoussin(a)reactos.org> wrote:
>   tkreuzer(a)svn.reactos.org a écrit :
> >   Author: tkreuzer
> >  Date: Mon Aug 10 17:09:14 2009
> >  New Revision: 42596
> >
> >  +static
> >  +DWORD
> >  +EngpFileIoRequest(
> >  +    PFILE_OBJECT pFileObject,
> >  +    ULONG   ulMajorFunction,
> >  +    LPVOID  lpBuffer,
> >  +    DWORD   nBufferSize,
> >  +    ULONGLONG  ullStartOffset,
> >  +    OUT LPDWORD lpInformation)
> >  +{ 
>  [...]
>
> >   +        return STATUS_INVALID_PARAMETER; 
>  [...]
>
> >   +        return FALSE; 
>  [...]
>
> >   +    return NT_SUCCESS(Status);
> >  +} 
>  I don't really understand what is supposed to return EngpFileIoRequest?
>  A DWORD, a BOOLEAN, or a NTSTATUS?
>
>
>  Hervé
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

win32k is full of static. What's wrong with it?


Alex Ionescu schrieb:
>   And since when is static used in ReactOS kernel code?
>
>  Best regards,
>  Alex Ionescu
>
>
>
>  On Mon, Aug 10, 2009 at 10:51 AM, Hervé Poussineau<hpoussin(a)reactos.org> wrote:
>    
> >   tkreuzer(a)svn.reactos.org a écrit :
> > >   Author: tkreuzer
> > >  Date: Mon Aug 10 17:09:14 2009
> > >  New Revision: 42596
> > >
> > >  +static
> > >  +DWORD
> > >  +EngpFileIoRequest(
> > >  +    PFILE_OBJECT pFileObject,
> > >  +    ULONG   ulMajorFunction,
> > >  +    LPVOID  lpBuffer,
> > >  +    DWORD   nBufferSize,
> > >  +    ULONGLONG  ullStartOffset,
> > >  +    OUT LPDWORD lpInformation)
> > >  +{ 
> >  [...]
> >
> > >   +        return STATUS_INVALID_PARAMETER; 
> >  [...]
> >
> > >   +        return FALSE; 
> >  [...]
> >
> > >   +    return NT_SUCCESS(Status);
> > >  +} 
> >  I don't really understand what is supposed to return EngpFileIoRequest?
> >  A DWORD, a BOOLEAN, or a NTSTATUS?
> >
> >
> >  Hervé
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >       
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>