Re: [ros-dev] [ros-diffs] [pschweitzer] 65462: [NTFS] - In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names. - In CompareFileName(), handle the fact that for Win32 & DOS we do ...

[Thomas Faber]

On 2014-11-23 10:49, pschweitzer(a)svn.reactos.org wrote:
>   +           
> ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, FileName, TRUE))); 

You need NT_VERIFY here or this will break debug builds.

[Hermès BÉLUSCA - MAÏTO]

Or just do the good old:

Status = RtlUpcaseBlah();
ASSERT(NT_SUCCESS(Status));

To separate what's execution code to what's just validity checks
(assertions). And yes I know that NT_VERIFY exists too.

H.

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Thomas Faber
Envoyé : lundi 24 novembre 2014 17:05
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 65462: [NTFS] - In
NtfsQueryDirectory(), don't upcase name in dir search pattern, it can
conflict with POSIX names. - In CompareFileName(), handle the fact that for
Win32 & DOS we do ...

On 2014-11-23 10:49, pschweitzer(a)svn.reactos.org wrote:
>   +           
> ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, 
FileName, TRUE)));


You need NT_VERIFY here or this will break debug builds.

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev