Re: [ros-diffs] [cwittich] 20720: fix building with MSVC

[Thomas Weidenmueller]

[e-mail] wrote:
> GetFileTitle(szFileName, Globals.szFileTitle, sizeof(Globals.szFileTitle));
> GetFileTitle(szFileName, Globals.szFileTitle, wcslen(Globals.szFileTitle));

This change is wrong, sizeof(Globals.szFileTitle) is correct. The last
parameter is the size of the buffer the second parameter represents.

- Thomas

[Thomas Weidenmueller]

Thomas Weidenmueller wrote:
> [e-mail] wrote:
> > GetFileTitle(szFileName, Globals.szFileTitle, sizeof(Globals.szFileTitle));
> > GetFileTitle(szFileName, Globals.szFileTitle, wcslen(Globals.szFileTitle));
>
> This change is wrong, sizeof(Globals.szFileTitle) is correct. The last
> parameter is the size of the buffer the second parameter represents.

I mean, sizeof(Globals.szFileTitle) / sizeof(Globals.szFileTitle[0])
would be correct.

- Thomas