Re: [ros-dev] [ros-diffs] [tkreuzer] 25768: Property sheet: - Set focus to defpushbutton or to first WC_EDIT child window if present, like it works on windows. - update wine diff This fixes the regression in 2nd stage setup when no keyboard focus was present.

[Thomas Weidenmueller]

tkreuzer(a)svn.reactos.org wrote:
>   Author: tkreuzer
>  Date: Sun Feb 11 01:02:45 2007
>  New Revision: 25768
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=25768&view=rev
>  Log:
>  Property sheet:
>  - Set focus to defpushbutton or to first WC_EDIT child window if present, like it works
> on windows.
>  - update wine diff
>  This fixes the regression in 2nd stage setup when no keyboard focus was present.
>  
>  Modified:
>      trunk/reactos/dll/win32/comctl32/comctl32_ros.diff
>      trunk/reactos/dll/win32/comctl32/propsheet.c 
Why is it so difficult to keep differences with wine code as minimal as
possible? Who's supposed to merge all these things in case conflicts
appear in the future? Why not submit the patches to wine?

- Thomas

[Aleksey Bragin]

He could try submitting that to WineHQ...

WBR,
Aleksey Bragin.

On Feb 11, 2007, at 1:07 AM, Thomas Weidenmueller wrote:

>   tkreuzer(a)svn.reactos.org wrote:
> >   Author: tkreuzer
> >  Date: Sun Feb 11 01:02:45 2007
> >  New Revision: 25768
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=25768&view=rev
> >  Log:
> >  Property sheet:
> >  - Set focus to defpushbutton or to first WC_EDIT child window if  
> >  present, like it works on windows.
> >  - update wine diff
> >  This fixes the regression in 2nd stage setup when no keyboard  
> >  focus was present.
> >
> >  Modified:
> >      trunk/reactos/dll/win32/comctl32/comctl32_ros.diff
> >      trunk/reactos/dll/win32/comctl32/propsheet.c 
>  Why is it so difficult to keep differences with wine code as  
>  minimal as
>  possible? Who's supposed to merge all these things in case conflicts
>  appear in the future? Why not submit the patches to wine?
>
>  - Thomas