Re: [ros-dev] [ros-diffs] [fireball] 53446: [NTDLL/LDR] - Fix wrong loop condition which would often lead to heap underread. - Fix wrong subkey string length calculation, which would result in an incorrect string being used...

[Ged Murphy]

fireball(a)svn.reactos.org wrote:

>   - Use Zw* functions instead of Nt* where necessary in
> LdrQueryImageFileKeyOption(). 
'where necessary'm I don't understand this change.
People prefer (and Microsoft recommend) that Nt* is used in usermode.
Nt and Zw APIs point to the same address in usermode, so why is it necessary?

Ged.

[Aleksey Bragin]

On Aug 26, 2011, at 12:05 PM, Ged Murphy wrote:

>   fireball(a)svn.reactos.org wrote:
>
> >   - Use Zw* functions instead of Nt* where
> > necessary in  
> >  LdrQueryImageFileKeyOption(). 
>  'where necessary'm I don't understand this change.
>  People prefer (and Microsoft recommend) that Nt* is used in usermode.
>  Nt and Zw APIs point to the same address in usermode, so why is it  
>  necessary? 
This was a test for attention, and so far I got a few notices in IRC  
and one in ros-dev. Good!

Seriously, the change slipped through because I was editing source  
code of both RTL (which works both at umode and kmode) and NTDLL/LDR  
(which is only umode) a while ago. Of course, Nt is "preferable" in  
usermode because there is just no reason to use Zw there.


WBR,
Aleksey Bragin.