Regression in r75772 broke multiple disk drive support

[Dimitrij Klingbeil]

Hi all,

It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
has introduced some significant unintended consequences.
Ever since I can't get ReactOS to recognize a second hard drive.

My configuration is like this:
- ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
- VM configured for Windows 2003 32-bit, with 1 CPU
- Emulated Chipset: PIIX3, no USB, no Audio, no Serial
- AMD-V active, Nested Paging active,
- No paravirtualization interface, no guest additions
- Emulated Storage: SATA controller with 4 ports
  - Port 0: First Hard disk (has partition C)
  - Port 1: Second Hard disk (has partition D)
  - Port 3: CDROM (to install ReactOS from, E)
- Each hard disk has one single primary partition (FAT formatted by an older
ReactOS setup)
- On C I install ReactOS (re-formatting the partition in the process)
- On D there is some data (a small collection of program installers to try
out)

Now, inside ReactOS I cannot see the contents of D. The drive itself shows
up, but unformatted and of a zero size. In the revisions before 75772 there
were no problems, I could see the drive and use the data on it.
Re-installing r75771 shows that the drive image is OK and the data is still
there, so it's not the data that was corrupted.

If I insert a CDROM image (with ReactOS already running), the CDROM drive
(E) suddently disappears and D now has the CDROM in it (so happened just now
with r75872). When I eject the CDROM, D becomes empty but still shows the
icon for a CDROM. E does not re-appear.

75772 looks like a very small change, but something must have gone really
off the rails...

Regards,
Dimitrij

P.S. This was at first sent from the wrong (not subscribed to the list)
address by mistake. I think the first one was rejected by the list SW,
but sorry if the message appears twice.

[Pierre Schweitzer]

Ack. See https://jira.reactos.org/browse/CORE-13805

Thanks for the report.

Le 17/09/2017 à 17:39, Dimitrij Klingbeil a écrit :
> Hi all,
>
> It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
> has introduced some significant unintended consequences.
> Ever since I can't get ReactOS to recognize a second hard drive.
>
> My configuration is like this:
> ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
> VM configured for Windows 2003 32-bit, with 1 CPU
> Emulated Chipset: PIIX3, no USB, no Audio, no Serial
> AMD-V active, Nested Paging active,
> No paravirtualization interface, no guest additions
> Emulated Storage: SATA controller with 4 ports
>
> - Port 0: First Hard disk (has partition C)
>  - Port 1: Second Hard disk (has partition D)
>  - Port 3: CDROM (to install ReactOS from, E)
> Each hard disk has one single primary partition (FAT formatted by an
>
> older
> ReactOS setup)
> On C I install ReactOS (re-formatting the partition in the process)
> On D there is some data (a small collection of program installers to try
>
> out)
>
> Now, inside ReactOS I cannot see the contents of D. The drive itself shows
> up, but unformatted and of a zero size. In the revisions before 75772 there
> were no problems, I could see the drive and use the data on it.
> Re-installing r75771 shows that the drive image is OK and the data is still
> there, so it's not the data that was corrupted.
>
> If I insert a CDROM image (with ReactOS already running), the CDROM drive
> (E) suddently disappears and D now has the CDROM in it (so happened just
> now
> with r75872). When I eject the CDROM, D becomes empty but still shows the
> icon for a CDROM. E does not re-appear.
>
> 75772 looks like a very small change, but something must have gone really
> off the rails...
>
> Regards,
> Dimitrij
>
> P.S. This was at first sent from the wrong (not subscribed to the list)
> address by mistake. I think the first one was rejected by the list SW,
> but sorry if the message appears twice.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

[Pierre Schweitzer]

This regression got fixed with r75911.
Can you confirm it's OK on your side?

Le 18/09/2017 à 22:41, Pierre Schweitzer a écrit :
> Ack. See https://jira.reactos.org/browse/CORE-13805
>
> Thanks for the report.
>
> Le 17/09/2017 à 17:39, Dimitrij Klingbeil a écrit :
> > Hi all,
> >
> > It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
> > has introduced some significant unintended consequences.
> > Ever since I can't get ReactOS to recognize a second hard drive.
> >
> > My configuration is like this:
> > ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
> > VM configured for Windows 2003 32-bit, with 1 CPU
> > Emulated Chipset: PIIX3, no USB, no Audio, no Serial
> > AMD-V active, Nested Paging active,
> > No paravirtualization interface, no guest additions
> > Emulated Storage: SATA controller with 4 ports
> >
> > - Port 0: First Hard disk (has partition C)
> >  - Port 1: Second Hard disk (has partition D)
> >  - Port 3: CDROM (to install ReactOS from, E)
> > Each hard disk has one single primary partition (FAT formatted by an
> >
> > older
> > ReactOS setup)
> > On C I install ReactOS (re-formatting the partition in the process)
> > On D there is some data (a small collection of program installers to try
> >
> > out)
> >
> > Now, inside ReactOS I cannot see the contents of D. The drive itself shows
> > up, but unformatted and of a zero size. In the revisions before 75772 there
> > were no problems, I could see the drive and use the data on it.
> > Re-installing r75771 shows that the drive image is OK and the data is still
> > there, so it's not the data that was corrupted.
> >
> > If I insert a CDROM image (with ReactOS already running), the CDROM drive
> > (E) suddently disappears and D now has the CDROM in it (so happened just
> > now
> > with r75872). When I eject the CDROM, D becomes empty but still shows the
> > icon for a CDROM. E does not re-appear.
> >
> > 75772 looks like a very small change, but something must have gone really
> > off the rails...
> >
> > Regards,
> > Dimitrij
> >
> > P.S. This was at first sent from the wrong (not subscribed to the list)
> > address by mistake. I think the first one was rejected by the list SW,
> > but sorry if the message appears twice.
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

[Dimitrij Klingbeil]

Hi Pierre

Some parts of this issue seem fixed, but not all - at least not reliably.

The second drive does appear at first. But as soon as something is done
with it (like starting a program / an installer from it), the system will
become rather temperamental. While the program does run, after the next
ReactOS reboot, the drive disappears again, and this time it completely
disappears rather than looking empty or raw-mounted. After the subsequent
reboot, the drive appears again. Hard to tell, why.

At least that's what I've tried with an otherwise freshly formatted drive:

- Create a directory "Software"
- Put inside the Firefox 45.9.0-ESR installer
- Start the installer
- Wait until it finishes extracting its contents in a temp location
- The installer will greet one with its "Welcome" screen
- Rather than continuing, reboot ReactOS now
- After the reboot, drive D is no longer there
- Reboot ReactOS again
- Drive D re-appears and its contents are still in place
- Try the installer again (possibly letting it finish)
- Reboot again, and the drive disappears
- Reboot an additional time, and the drive re-appears
- etc. repetitively, ad infinitum
- One reboot "breaks" something, the next one "fixes" it again

This was seen with ReactOS r75915, tested just a moment ago.

Regards
Dimitrij

----- Original Message ----- 
From: "Pierre Schweitzer" [e-mail]
To: [e-mail]
Sent: Wednesday, September 20, 2017 10:48 AM
Subject: Re: [ros-dev] Regression in r75772 broke multiple disk drive 
support
> This regression got fixed with r75911.
> Can you confirm it's OK on your side?
>
> Le 18/09/2017 à 22:41, Pierre Schweitzer a écrit :
> > Ack. See https://jira.reactos.org/browse/CORE-13805
> >
> > Thanks for the report.
> >
> > Le 17/09/2017 à 17:39, Dimitrij Klingbeil a écrit :
> > > Hi all,
> > >
> > > It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
> > > has introduced some significant unintended consequences.
> > > Ever since I can't get ReactOS to recognize a second hard drive.
> > >
> > > My configuration is like this:
> > > ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
> > > VM configured for Windows 2003 32-bit, with 1 CPU
> > > Emulated Chipset: PIIX3, no USB, no Audio, no Serial
> > > AMD-V active, Nested Paging active,
> > > No paravirtualization interface, no guest additions
> > > Emulated Storage: SATA controller with 4 ports
> > > Port 0: First Hard disk (has partition C)
> > > Port 1: Second Hard disk (has partition D)
> > > Port 3: CDROM (to install ReactOS from, E)
> > > Each hard disk has one single primary partition (FAT formatted by an
> > >
> > > older
> > > ReactOS setup)
> > > On C I install ReactOS (re-formatting the partition in the process)
> > > On D there is some data (a small collection of program installers to
> > >
> > > try
> > > out)
> > >
> > > Now, inside ReactOS I cannot see the contents of D. The drive itself 
> > > shows
> > > up, but unformatted and of a zero size. In the revisions before 75772 
> > > there
> > > were no problems, I could see the drive and use the data on it.
> > > Re-installing r75771 shows that the drive image is OK and the data is 
> > > still
> > > there, so it's not the data that was corrupted.
> > >
> > > If I insert a CDROM image (with ReactOS already running), the CDROM 
> > > drive
> > > (E) suddently disappears and D now has the CDROM in it (so happened just
> > > now
> > > with r75872). When I eject the CDROM, D becomes empty but still shows 
> > > the
> > > icon for a CDROM. E does not re-appear.
> > >
> > > 75772 looks like a very small change, but something must have gone 
> > > really
> > > off the rails...
> > >
> > > Regards,
> > > Dimitrij
> > >
> > > P.S. This was at first sent from the wrong (not subscribed to the list)
> > > address by mistake. I think the first one was rejected by the list SW,
> > > but sorry if the message appears twice.
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
>
> -- 
> Pierre Schweitzer <pierre at reactos.org>
> System & Network Administrator
> Senior Kernel Developer
> ReactOS Deutschland e.V.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Dimitrij Klingbeil]

Hi All

After the fixes in r75772 and 75911 the two-disk behaviour now seems
to have become like this:

- One time ReactOS starts, both disks (C and D) are there (CDROM is E)
- Next reboot, only C is there, the CDROM has become D instead
- Another reboot, everything back all right
- Another reboot, and D is again missing (and CDROM is again D)
- And so on, consistently, every other time

Something seems to be setting some flag on the second drive that prevents
it from showing up the next boot, and then one boot later, it reapears.

Is it just my setup or is anyone else also seeng this problem?

Regards
Dimitrij

P.S. In's not necessary (as I wrote last time) to try to run a program
from the second drive. Just opening it with Explorer to see that it's
there, then rebooting ReactOS is enough. Every other time it's missing.

----- Original Message ----- 
From: "Pierre Schweitzer" [e-mail]
To: [e-mail]
Sent: Wednesday, September 20, 2017 10:48 AM
Subject: Re: [ros-dev] Regression in r75772 broke multiple disk drive 
support
> This regression got fixed with r75911.
> Can you confirm it's OK on your side?
>
> Le 18/09/2017 à 22:41, Pierre Schweitzer a écrit :
> > Ack. See https://jira.reactos.org/browse/CORE-13805
> >
> > Thanks for the report.
> >
> > Le 17/09/2017 à 17:39, Dimitrij Klingbeil a écrit :
> > > Hi all,
> > >
> > > It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
> > > has introduced some significant unintended consequences.
> > > Ever since I can't get ReactOS to recognize a second hard drive.
> > >
> > > My configuration is like this:
> > > ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
> > > VM configured for Windows 2003 32-bit, with 1 CPU
> > > Emulated Chipset: PIIX3, no USB, no Audio, no Serial
> > > AMD-V active, Nested Paging active,
> > > No paravirtualization interface, no guest additions
> > > Emulated Storage: SATA controller with 4 ports
> > > Port 0: First Hard disk (has partition C)
> > > Port 1: Second Hard disk (has partition D)
> > > Port 3: CDROM (to install ReactOS from, E)
> > > Each hard disk has one single primary partition (FAT formatted by an
> > >
> > > older
> > > ReactOS setup)
> > > On C I install ReactOS (re-formatting the partition in the process)
> > > On D there is some data (a small collection of program installers to
> > >
> > > try
> > > out)
> > >
> > > Now, inside ReactOS I cannot see the contents of D. The drive itself 
> > > shows
> > > up, but unformatted and of a zero size. In the revisions before 75772 
> > > there
> > > were no problems, I could see the drive and use the data on it.
> > > Re-installing r75771 shows that the drive image is OK and the data is 
> > > still
> > > there, so it's not the data that was corrupted.
> > >
> > > If I insert a CDROM image (with ReactOS already running), the CDROM 
> > > drive
> > > (E) suddently disappears and D now has the CDROM in it (so happened just
> > > now
> > > with r75872). When I eject the CDROM, D becomes empty but still shows 
> > > the
> > > icon for a CDROM. E does not re-appear.
> > >
> > > 75772 looks like a very small change, but something must have gone 
> > > really
> > > off the rails...
> > >
> > > Regards,
> > > Dimitrij
> > >
> > > P.S. This was at first sent from the wrong (not subscribed to the list)
> > > address by mistake. I think the first one was rejected by the list SW,
> > > but sorry if the message appears twice.
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
>
> -- 
> Pierre Schweitzer <pierre at reactos.org>
> System & Network Administrator
> Senior Kernel Developer
> ReactOS Deutschland e.V.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev