A call for help getting putty working

[art yerkes]

I'm hoping to get putty working to use as another test case for the network
code.  I'm running into problems right now, however and could really use
a hand.

There are two versions of putty in here, built with symbols as well as a
diff against the original sources and a mingw-able makefile named 
makefile.mgw

I haven't tried the mingw makefile on windows but it shouldn't take too
much effort.

putty-noshow differs from the release putty only in that it contains
debug messages and symbols.  The putty dialog is created and the caret
timer even fires, but the window is never shown.  w3seek thinks that
the dialog functions in user32 and win32k are correct, but the dialog
shows on windows and wine so something is wrong.

If I add a ShowWindow as in putty-show, the dialog shows, so the
problem is clearly in reactos.

I'm seeing some random crashes as well accessing the registry that
will be the subject of another mail.

my putty musings: http://64.81.145.152/~arty/putty.zip
Putty page: http://www.chiark.greenend.org.uk/~sgtatham/putty/
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Casper Hornstrup]

> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of art yerkes
> Sent: 19. november 2004 20:28
> To: [e-mail]
> Subject: [ros-dev] A call for help getting putty working
>
> my putty musings: http://64.81.145.152/~arty/putty.zip
> Putty page: http://www.chiark.greenend.org.uk/~sgtatham/putty/

Is it another version than this one which does not seem to have this problem:
http://www.reactos.com/index.php/en/content/view/full/626

The screenshot author may remember the version.

Casper

[art yerkes]

Even if another version works it'd be nice to work with it unmodified and
as compiled by the author.

1) My thoughts are twofold; putty works on wine and windows, and so a
compatible system such as reactos ought to be able to the same.  I think
having CreateDialog work right is not so much to ask.

2) We get no credibility having to port apps to run on reactos.  Sometimes
I do patch an app so i can get past a known problem by my goal is always
ultimately to run the app unpatched.  My guess is that an eventual end
user will expect the author's version to work.

Honestly I don't know if putty's author Simon Tatham has done something
wrong with the win32 api or we have, and I'm not interested in hunting
for a specific version that works.  What I am interested in is fixing
bugs in reactos that may affect some other application.  I have a feeling
that other apps may appear to fail silently but actually just be waiting
for some invisible hand to show their dialogs.  Putty should now be a
reasonable target as we theoretically implement everything it needs.

Sorry if this doesn't fit with our current development arc.  I'm getting
more resistance than I anticipated.
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Casper Hornstrup]

I was just trying to figure out if the problem was due to an
unimplemented part of ReactOS or a regression of ReactOS.

Casper
> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of art yerkes
> Sent: 19. november 2004 22:53
> To: ReactOS Development List
> Cc: [e-mail]
> Subject: Re: [ros-dev] A call for help getting putty working
>
> Even if another version works it'd be nice to work with it 
> unmodified and as compiled by the author.
> My thoughts are twofold; putty works on wine and windows,
>
> and so a compatible system such as reactos ought to be able 
> to the same.  I think having CreateDialog work right is not 
> so much to ask.
> We get no credibility having to port apps to run on
>
> reactos.  Sometimes I do patch an app so i can get past a 
> known problem by my goal is always ultimately to run the app 
> unpatched.  My guess is that an eventual end user will expect 
> the author's version to work.
>
> Honestly I don't know if putty's author Simon Tatham has done 
> something wrong with the win32 api or we have, and I'm not 
> interested in hunting for a specific version that works.  
> What I am interested in is fixing bugs in reactos that may 
> affect some other application.  I have a feeling that other 
> apps may appear to fail silently but actually just be waiting 
> for some invisible hand to show their dialogs.  Putty should 
> now be a reasonable target as we theoretically implement 
> everything it needs.
>
> Sorry if this doesn't fit with our current development arc.  
> I'm getting more resistance than I anticipated.  
> --
> Here's a simple experiment. Stand on a train track between 
> two locomotives which are pushing on you with equal force in 
> opposite directions. You will exhibit no net motion. None the 
> less, you may soon begin to notice that something important 
> is happening.
> -- Robert Stirniman
> _______________________________________________
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[Filip Navara]

Casper Hornstrup wrote:
> Is it another version than this one which does not seem to have this problem:
> http://www.reactos.com/index.php/en/content/view/full/626
>
> The screenshot author may remember the version.

It's mine screenshot. The PuTTY used here is 0.53b official release.

Regards,
Filip

[Ge van Geldorp]

> From: art yerkes
>
> I'm hoping to get putty working to use as another test case 
> for the network code.  I'm running into problems right now, 
> however and could really use a hand.

The problem is caused by us not handling the WM_SETREDRAW message. The main
dialog window is sent this message twice in windlg.c, first with a FALSE
parameter, then with a TRUE parameter. This second call causes the window to
become visible in Windows and Wine. I'll see if I can fix it in ReactOS.

Ge van Geldorp.

[art yerkes]

On Sat, 20 Nov 2004 00:02:00 +0100
"Ge van Geldorp" [e-mail] wrote:
> > From: art yerkes
> >
> > I'm hoping to get putty working to use as another test case 
> > for the network code.  I'm running into problems right now, 
> > however and could really use a hand.
>
> The problem is caused by us not handling the WM_SETREDRAW message. The main
> dialog window is sent this message twice in windlg.c, first with a FALSE
> parameter, then with a TRUE parameter. This second call causes the window to
> become visible in Windows and Wine. I'll see if I can fix it in ReactOS.
>
> Ge van Geldorp.

Thanks.  I noticed those messages but didn't know if they were related.
I've seen a couple other apps that do something similar (irc clients),
and i'll try them again after it's fixed.
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Ge van Geldorp]

> From: art yerkes
>
> Thanks.  I noticed those messages but didn't know if they 
> were related. I've seen a couple other apps that do something 
> similar (irc clients), and i'll try them again after it's fixed.

PuTTY now displays again.

Ge van Geldorp.