Re: [ros-dev] [ros-diffs] [sir_richard] 48475: [KERNEL32]: While working on the CMAKE branch, Amine and myself discovered a rather serious issue in kernel32 (and perhaps other libraries as well). Unlike rbuild, CMake does not allow you to export non-existant DLL functions (try it: add "poopyhead" in kernel32's exports under RBuild, and will it export "poopyhead", God knowing what that will actually link to). As an additional feature on top of the "allow non-existing functions to be exported" "feature", beca

[Aleksey Bragin]

I have a couple of questions/suggestions. Even if it was a mistake to  
commit it to trunk, I still express my opinion because I think it's  
important for the changes to stay in trunk.

1. Channel-based system is preferred to the plain NDEBUG/DPRINT one.  
Kernel32 should not really be an exception. If there is something  
wrong, it's better to put some more time into it and fix the actual  
problem in that debug library. Everyone who ever tried to debug any  
usermode app in ROS, would understand.
2. .pspec file was also invented as a consistent way to be compatible  
with different compilers. Winebuild generates stubs for entries  
marked as "stub", so it's quite controllable.
3. Everything else is great, nice to see that mess being finally  
cleaned up.

WBR,
Aleksey Bragin.

On Aug 7, 2010, at 9:02 AM, sir_richard(a)svn.reactos.org wrote:

>   Author: sir_richard
>  Date: Sat Aug  7 05:02:58 2010
>  New Revision: 48475
>
>  URL: http://svn.reactos.org/svn/reactos?rev=48475&view=rev
>  Log:
>  [KERNEL32]: While working on the CMAKE branch...

[Colin Finck]

Aleksey Bragin wrote:
>   2. .pspec file was also invented as a consistent way
> to be compatible
>  with different compilers. Winebuild generates stubs for entries marked
>  as "stub", so it's quite controllable. 
Usual .spec files are the ones processed by Winebuild.
.pspec (= preprocessed .spec) is an "invention" of us and they are .spec 
files which are run through the C preprocessor first. Unfortunately, 
this isn't just cumbersome, but also means that we need to remove all 
comments from .pspec files, because the # character cannot be used for 
them anymore.

We introduced these .pspec files when we had no way of defining 
different exports for different architectures, but Winebuild supports an 
-arch=? flag for each architecture now. This should be the way to go.

Cheers,

Colin