RE: [ros-dev] Re: [ros-svn] [gedmurphy] 18814: - start of a rewri te for ipconfig

[Murphy, Ged (Bolton)]

> -----Original Message-----
> From: Murphy, Ged (Bolton) [mailto:[e-mail]] 
> Sent: 28 October 2005 08:05
> To: 'ReactOS Development List'
> Subject: RE: [ros-dev] Re: [ros-svn] [gedmurphy] 18814: - 
> start of a rewri te for ipconfig
> > -----Original Message-----
> > From: Tim Jobling [mailto:[e-mail]] 
> > Sent: 28 October 2005 00:50
> > To: [e-mail]
> > Subject: [ros-dev] Re: [ros-svn] [gedmurphy] 18814: - start 
> > of a rewrite for ipconfig
> >
> > Ged,
> >
> > Whilst I applaud your efforts in tidying and advancing 
> > ipconfig.c, I must 
> > say that I think it is bad form to remove the previously 
> > named authors from 
> > the header and replace with only your own name.
> >
> > Kind regards,
> > Tim Jobling.
>
> Who was on it before me?
> I stripped it down and started again.
>
> Ged.

I just diffed against the previous revision and noted Rob Dickinson and your
name.
Pretty much all of the code from that revision has been replaced, with the
acception of the manner in which the command line is parsed. 
http://svn.reactos.com/viewcvs/trunk/reactos/apps/utils/net/ipconfig/ipconfi
g.c?rev=18814&r1=18297&r2=18814

I would assume this is classed as a rewrite and previous revision details
aren't therefore noted in the source, but are accessible via the SVN logs.

If this is incorrect, or you feel offended, I will put the revision history
back in the file.

Ged.

************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
[e-mail] 
mailto:[e-mail] and then delete this message.

Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com

[Tim Jobling]

> I just diffed against the previous revision and noted Rob Dickinson and 
> your
> name.
> Pretty much all of the code from that revision has been replaced, with the
> acception of the manner in which the command line is parsed.
> http://svn.reactos.com/viewcvs/trunk/reactos/apps/utils/net/ipconfig/ipconfi
> g.c?rev=18814&r1=18297&r2=18814
>
> I would assume this is classed as a rewrite and previous revision details
> aren't therefore noted in the source, but are accessible via the SVN logs.
>
> If this is incorrect, or you feel offended, I will put the revision 
> history
> back in the file.
>
> Ged.

No need to add it back.  When I looked at it last night I glanced at your 
_tmain function, containing the command line is parsing, I noticed it looked 
almost identical to my main. So I questioned if it really was a rewrite. 
Having read through the rest of the file, I see that most of it is new.

No problem.

Tim

___________________________________________________________ 
To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com