Re: [ros-dev] [ros-diffs] [cfinck] 68253: [SPOOLSS] Halfplement and document the undocumented but exported MarshallDownStructure API. Information about this API was exclusively gained by writing a custom XML file for rohita...

[Alex Ionescu]

On Wed, Jun 24, 2015 at 9:26 AM, <cfinck(a)svn.reactos.org> wrote:

>   cbSize 

Well, you may at least want to validate that your dwOffsets are within
cbSize?

Best regards,
Alex Ionescu

[Colin Finck]

Am 30.06.2015 um 15:17 schrieb Alex Ionescu:
>   Well, you may at least want to validate that your
> dwOffsets are
>  within cbSize? 
I had my tests under Windows and I was able to put all kinds of bogus
values into cbSize, cbPerElementSize and cbStructureSize, without any
visible effect on the function output.
So I wanted to leave it that way for compatibility.


Cheers,

Colin

[Hermès BÉLUSCA - MAÏTO]

Would it be possible that windows somewhat fix them automagically?
H.

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Colin Finck
Envoyé : mardi 30 juin 2015 18:18
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [cfinck] 68253: [SPOOLSS] Halfplement and
document the undocumented but exported MarshallDownStructure API.
Information about this API was exclusively gained by writing a custom XML
file for rohita...

Am 30.06.2015 um 15:17 schrieb Alex Ionescu:
>   Well, you may at least want to validate that your
> dwOffsets are within 
>  cbSize? 
I had my tests under Windows and I was able to put all kinds of bogus values
into cbSize, cbPerElementSize and cbStructureSize, without any visible
effect on the function output.
So I wanted to leave it that way for compatibility.


Cheers,

Colin

[Colin Finck]

Am 30.06.2015 um 18:41 schrieb Hermès BÉLUSCA - MAÏTO:
>   Would it be possible that windows somewhat fix them
> automagically? 
As I said in the commit message, I didn't need these parameters at all
for the functionality I observed through black-box testing. Furthermore,
the function only modifies the given structure, not the parameters, so
there is no way to return "fixed" values for them.


- Colin